Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datepicker): add ability to also show time #9570

Merged
merged 12 commits into from Mar 5, 2022

Conversation

NathanWalker
Copy link
Contributor

@NathanWalker NathanWalker commented Sep 23, 2021

PR Checklist

What is the current behavior?

DatePicker did not allow the ability to show a time picker alongside the date. Although there is a distinct TimePicker in core, it was often not flexible enough in the sense of how one would often need to use a date picker with time picker.

What is the new behavior?

DatePicker now supports a showTime property which will allow the date and the time to be set properly.
This also adds properties for hour, minute and second as well as a proper attribute for iosPreferredDatePickerStyle to allow easy dynamic view binding.

Further this can be useful in scenarios where this plugin may not fit the exact use case given how it creates two separate native controls vs. just one with these changes.

@cla-bot cla-bot bot added the cla: yes label Sep 23, 2021
@NathanWalker NathanWalker added this to the 8.2 milestone Oct 21, 2021
@rigor789
Copy link
Member

@rigor789 rigor789 commented Feb 17, 2022

This still needs the Android side done before we can merge.

@rigor789 rigor789 marked this pull request as draft Feb 17, 2022
@NathanWalker NathanWalker changed the base branch from master to release/8.2.0 Mar 4, 2022
@NathanWalker NathanWalker marked this pull request as ready for review Mar 5, 2022
@NathanWalker NathanWalker merged commit ab4e47a into release/8.2.0 Mar 5, 2022
2 of 3 checks passed
@NathanWalker NathanWalker deleted the feat/ui-datepicker-with-time-option branch Mar 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants