Skip to content
main
Switch branches/tags
cpython/Modules/
Go to file
cpython/Modules/

Latest commit

@encukou
encukou gh-93649: Split vectorcall testing from _testcapimodule.c (GH-94549)
be862b4 Jul 8, 2022
gh-93649: Split vectorcall testing from _testcapimodule.c (GH-94549) 
The `_testcapimodule.c` file is getting too large to work with effectively.
This PR lays out a general structure of how tests can be split up, with more splitting to come later if the structure is OK.

Vectorcall tests aren't the biggest issue -- it's just an area I want to work on next, so I'm starting here.
An issue specific to vectorcall tests is that it wasn't clear that e.g. `MethodDescriptor2` is related to testing vectorcall: the `/* Test PEP 590 */` section had an ambiguous end. Separate file should make things like this much clearer.
OTOH, for some pieces it might not be clear where they should be -- I left `meth_fastcall` with tests of the other calling conventions. IMO, even with the ambiguity it's still worth it to split the huge file up.

I'm not sure about the buildsystem changes, hopefully CI will tell me what's wrong.

@vstinner, @markshannon: Do you think this is a good idea?

Automerge-Triggered-By: GH:encukou
be862b4

Git stats

Files

Permalink
Failed to load latest commit information.
Type
Name
Latest commit message
Commit time
. .
_blake2
 
 
_ctypes
 
 
_decimal
 
 
_io
 
 
_multiprocessing
 
 
_sha3
 
 
_sqlite
 
 
_sre
 
 
_ssl
 
 
_testcapi
 
 
_xxtestfuzz
 
 
cjkcodecs
 
 
clinic
 
 
expat
 
 
README
 
 
Setup
 
 
Setup.bootstrap.in
 
 
Setup.stdlib.in
 
 
_abc.c
 
 
_asynciomodule.c
 
 
_bisectmodule.c
 
 
_bz2module.c
 
 
_codecsmodule.c
 
 
_collectionsmodule.c
 
 
_contextvarsmodule.c
 
 
_cryptmodule.c
 
 
_csv.c
 
 
_curses_panel.c
 
 
_cursesmodule.c
 
 
_datetimemodule.c
 
 
_dbmmodule.c
 
 
_elementtree.c
 
 
_functoolsmodule.c
 
 
_gdbmmodule.c
 
 
_hashopenssl.c
 
 
_heapqmodule.c
 
 
_json.c
 
 
_localemodule.c
 
 
_lsprof.c
 
 
_lzmamodule.c
 
 
_math.h
 
 
_opcode.c
 
 
_operator.c
 
 
_pickle.c
 
 
_posixsubprocess.c
 
 
_queuemodule.c
 
 
_randommodule.c
 
 
_scproxy.c
 
 
_ssl.c
 
 
_ssl.h
 
 
_ssl_data.h
 
 
_ssl_data_111.h
 
 
_ssl_data_300.h
 
 
_stat.c
 
 
_statisticsmodule.c
 
 
_struct.c
 
 
_testbuffer.c
 
 
_testcapi_feature_macros.inc
 
 
_testcapimodule.c
 
 
_testimportmultiple.c
 
 
_testinternalcapi.c
 
 
_testmultiphase.c
 
 
_threadmodule.c
 
 
_tkinter.c
 
 
_tracemalloc.c
 
 
_typingmodule.c
 
 
_uuidmodule.c
 
 
_weakref.c
 
 
_winapi.c
 
 
_xxsubinterpretersmodule.c
 
 
_zoneinfo.c
 
 
addrinfo.h
 
 
arraymodule.c
 
 
atexitmodule.c
 
 
audioop.c
 
 
binascii.c
 
 
cmathmodule.c
 
 
config.c.in
 
 
errnomodule.c
 
 
faulthandler.c
 
 
fcntlmodule.c
 
 
gc_weakref.txt
 
 
gcmodule.c
 
 
getaddrinfo.c
 
 
getbuildinfo.c
 
 
getnameinfo.c
 
 
getpath.c
 
 
getpath.py
 
 
getpath_noop.c
 
 
grpmodule.c
 
 
hashlib.h
 
 
itertoolsmodule.c
 
 
ld_so_aix.in
 
 
main.c
 
 
makesetup
 
 
makexp_aix
 
 
mathmodule.c
 
 
md5module.c
 
 
mmapmodule.c
 
 
nismodule.c
 
 
ossaudiodev.c
 
 
overlapped.c
 
 
posixmodule.c
 
 
posixmodule.h
 
 
pwdmodule.c
 
 
pyexpat.c
 
 
readline.c
 
 
resource.c
 
 
rotatingtree.c
 
 
rotatingtree.h
 
 
selectmodule.c
 
 
sha1module.c
 
 
sha256module.c
 
 
sha512module.c
 
 
signalmodule.c
 
 
socketmodule.c
 
 
socketmodule.h
 
 
spwdmodule.c
 
 
symtablemodule.c
 
 
syslogmodule.c
 
 
termios.c
 
 
testcapi_long.h
 
 
timemodule.c
 
 
tkappinit.c
 
 
tkinter.h
 
 
unicodedata.c
 
 
unicodedata_db.h
 
 
unicodename_db.h
 
 
winreparse.h
 
 
xxlimited.c
 
 
xxlimited_35.c
 
 
xxmodule.c
 
 
xxsubtype.c
 
 
zlibmodule.c
 
 

README 

Source files for standard library extension modules,
and former extension modules that are now builtin modules.