Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Py_XDECREF() module on fail in Py_mod_exec #90763

Closed
ov2k mannequin opened this issue Feb 1, 2022 · 3 comments · Fixed by #93078
Closed

Py_XDECREF() module on fail in Py_mod_exec #90763

ov2k mannequin opened this issue Feb 1, 2022 · 3 comments · Fixed by #93078
Labels
3.7 3.8 3.9 3.10 3.11 extension-modules type-bug

Comments

@ov2k
Copy link
Mannequin

@ov2k ov2k mannequin commented Feb 1, 2022

BPO 46605

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = None
closed_at = None
created_at = <Date 2022-02-01.21:49:08.439>
labels = ['type-bug', '3.8', '3.9', '3.10', '3.11', 'extension-modules', '3.7']
title = 'Py_XDECREF() module on fail in Py_mod_exec'
updated_at = <Date 2022-02-01.21:49:08.439>
user = 'https://bugs.python.org/ov2k'

bugs.python.org fields:

activity = <Date 2022-02-01.21:49:08.439>
actor = 'ov2k'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Extension Modules']
creation = <Date 2022-02-01.21:49:08.439>
creator = 'ov2k'
dependencies = []
files = []
hgrepos = []
issue_num = 46605
keywords = []
message_count = 1.0
messages = ['412315']
nosy_count = 1.0
nosy_names = ['ov2k']
pr_nums = []
priority = 'normal'
resolution = None
stage = None
status = 'open'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue46605'
versions = ['Python 3.7', 'Python 3.8', 'Python 3.9', 'Python 3.10', 'Python 3.11']
@ov2k
Copy link
Mannequin Author

@ov2k ov2k mannequin commented Feb 1, 2022

In some of the xx modules, a Py_mod_exec function steals a reference to the module argument when an error occurs (Py_XDECREF(m) after goto fail). It's a bit pernicious given the modules' stated intent to be used as a template, although I'm not sure how often this has actually happened. At the very least, I haven't noticed this outside the xx modules.

For Python <= 3.9, this affects xx_exec() in xxmodule.c and xx_modexec() in xxlimited.c. For Python >= 3.10, this affects xx_exec() in xxmodule.c and xx_modexec() in xxlimited_35.c.

@ov2k ov2k mannequin added 3.7 3.8 3.9 3.10 3.11 extension-modules type-bug labels Feb 1, 2022
@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
@erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented May 22, 2022

We might as well clean up the whole init functions of those two template modules. For example, xxmodule.c does not check the return value of PyModule_AddObject (and it should use PyModule_AddType instead).

erlend-aasland added a commit to erlend-aasland/cpython that referenced this issue May 22, 2022
@erlend-aasland
pythongh-90763: Modernise xx template module initialisation
4e16c6b 
Use C APIs such as PyModule_AddType instead of PyModule_AddObject.
Also remove incorrect module decrefs if module fails to initialise.
erlend-aasland added a commit to erlend-aasland/cpython that referenced this issue May 22, 2022
@erlend-aasland
pythongh-90763: Modernise xx template module initialisation
66c0613 
Use C APIs such as PyModule_AddType instead of PyModule_AddObject.
Also remove incorrect module decrefs if module fails to initialise.
@erlend-aasland erlend-aasland linked a pull request May 22, 2022 that will close this issue
gh-90763: Modernise xx template module initialisation #93078
Merged
erlend-aasland added a commit that referenced this issue Jun 10, 2022
@erlend-aasland
gh-90763: Modernise xx template module initialisation (#93078)
a87c9b5 
Use C APIs such as PyModule_AddType instead of PyModule_AddObject.
Also remove incorrect module decrefs if module fails to initialise.
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jun 10, 2022
@erlend-aasland @miss-islington
pythongh-90763: Modernise xx template module initialisation (pythonGH…
b8d6a08 
…-93078)

Use C APIs such as PyModule_AddType instead of PyModule_AddObject.
Also remove incorrect module decrefs if module fails to initialise.
(cherry picked from commit a87c9b5)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
erlend-aasland added a commit to erlend-aasland/cpython that referenced this issue Jun 10, 2022
@erlend-aasland
[3.11] pythongh-90763: Modernise xx template module initialisation (p…
931c9df 
…ythonGH-93078)

Use C APIs such as PyModule_AddType instead of PyModule_AddObject.
Also remove incorrect module decrefs if module fails to initialise.
(cherry picked from commit a87c9b5)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
miss-islington added a commit that referenced this issue Jun 10, 2022
@miss-islington @erlend-aasland
gh-90763: Modernise xx template module initialisation (GH-93078)
8d8251a 
Use C APIs such as PyModule_AddType instead of PyModule_AddObject.
Also remove incorrect module decrefs if module fails to initialise.
(cherry picked from commit a87c9b5)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
erlend-aasland added a commit that referenced this issue Jun 10, 2022
@erlend-aasland
[3.11] gh-90763: Modernise xx template module initialisation (GH-93078)…
175ed6e 
… (#93681)

Use C APIs such as PyModule_AddType instead of PyModule_AddObject.
Also remove incorrect module decrefs if module fails to initialise.
(cherry picked from commit a87c9b5)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
@erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Jun 10, 2022

Fixed by:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.7 3.8 3.9 3.10 3.11 extension-modules type-bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-90763: Modernise xx template module initialisation erlend-aasland/cpython
1 participant
@erlend-aasland