Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n:Inappropriate localization #46924

Merged
merged 1 commit into from Feb 3, 2022
Merged

i18n:Inappropriate localization #46924

merged 1 commit into from Feb 3, 2022

Conversation

mysmlz
Copy link
Contributor

@mysmlz mysmlz commented Nov 26, 2021

The previous version of the file incorrectly translated the keywords of some document comments into Chinese, which would be misleading

Fixes # Inappropriate localization in lib/zh-cn/diagnosticMessages.generated.json

The previous version of the file incorrectly translated the keywords of some document comments into Chinese, which would be misleading
@DanielRosenwasser DanielRosenwasser requested a review from csigs Nov 29, 2021
@typescript-bot
Copy link
Collaborator

@typescript-bot typescript-bot commented Nov 29, 2021

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

@typescript-bot typescript-bot added the For Uncommitted Bug label Nov 29, 2021
@DanielRosenwasser
Copy link
Member

@DanielRosenwasser DanielRosenwasser commented Nov 29, 2021

@csigs @PDostalek can you take a look?

@sandersn sandersn added this to Not started in PR Backlog Dec 7, 2021
@sandersn
Copy link
Member

@sandersn sandersn commented Jan 29, 2022

@sandersn sandersn moved this from Not started to Waiting on reviewers in PR Backlog Jan 29, 2022
@RyanCavanaugh RyanCavanaugh merged commit 46d1cb1 into microsoft:main Feb 3, 2022
5 checks passed
PR Backlog automation moved this from Waiting on reviewers to Done Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Uncommitted Bug
Projects
PR Backlog
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants