Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

configure: non pkg-config fallback ignores custom CFLAGS and LIBS #94801

Open
tiran opened this issue Jul 13, 2022 · 0 comments
Open

configure: non pkg-config fallback ignores custom CFLAGS and LIBS #94801

tiran opened this issue Jul 13, 2022 · 0 comments
Assignees
@erlend-aasland
Labels
3.11 3.12 build type-bug

Comments

@tiran
Copy link
Member

@tiran tiran commented Jul 13, 2022

Bug report

In configure.ac we have several fallbacks when pkg-config is missing or a package does not provide a .pc file. The fallbacks do not take custom cflags into account. For example the block for zlib does AC_CHECK_HEADERS([zlib.h]) and AC_CHECK_LIB([z]) without setting CFLAGS="$CFLAGS $ZLIB_CFLAGS" first.
@tiran tiran added type-bug build 3.11 3.12 labels Jul 13, 2022
tiran added a commit to tiran/cpython that referenced this issue Jul 13, 2022
@tiran
pythongh-94801: Use custom flags to check for headers and libs
938dd07
@bedevere-bot bedevere-bot mentioned this issue Jul 13, 2022
Merged
tiran added a commit to tiran/cpython that referenced this issue Jul 13, 2022
@tiran
Merge branch 'main' into pythongh-94801-cflags
6e49f8e
tiran added a commit to tiran/cpython that referenced this issue Jul 14, 2022
@tiran
pythongh-94801: Use custom flags to check for headers and libs
7bb04f3
tiran added a commit that referenced this issue Jul 15, 2022
@tiran
gh-94801: Use custom flags to check for headers and libs (#94802)
944ff8c
tiran added a commit to tiran/cpython that referenced this issue Jul 15, 2022
@tiran
[3.11] pythongh-94801: Use custom flags to check for headers and libs (…
96e6bec 
…pythonGH-94802).

(cherry picked from commit 944ff8c)

Co-authored-by: Christian Heimes <christian@python.org>
@bedevere-bot bedevere-bot mentioned this issue Jul 15, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erlend-aasland erlend-aasland

Labels
3.11 3.12 build type-bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tiran @erlend-aasland