Skip to content

gh-94930: skipitem() in getargs.c should return non-NULL on error #94931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Jul 17, 2022

@serhiy-storchaka serhiy-storchaka added type-bug An unexpected behavior, bug, or error needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Jul 17, 2022
@serhiy-storchaka serhiy-storchaka requested a review from methane July 17, 2022 15:10
@serhiy-storchaka serhiy-storchaka force-pushed the getargs-skipitem-PY_SSIZE_T_CLEAN branch from 3f3bec5 to 28d4995 Compare July 17, 2022 15:22
@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @serhiy-storchaka, I had trouble checking out the 3.11 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 067f0da33506f70c36a67d5f3d8d011c8dae10c9 3.11

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 18, 2022
…or (pythonGH-94931)

(cherry picked from commit 067f0da)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot
Copy link

GH-94963 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jul 18, 2022
@serhiy-storchaka serhiy-storchaka deleted the getargs-skipitem-PY_SSIZE_T_CLEAN branch July 18, 2022 15:07
@serhiy-storchaka serhiy-storchaka added needs backport to 3.11 only security fixes and removed needs backport to 3.11 only security fixes labels Jul 18, 2022
@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 18, 2022
…or (pythonGH-94931)

(cherry picked from commit 067f0da)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot
Copy link

GH-94964 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 18, 2022
miss-islington added a commit that referenced this pull request Jul 18, 2022
…-94931)

(cherry picked from commit 067f0da)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this pull request Jul 19, 2022
…ror (GH-94931) (GH-94963)

(cherry picked from commit 067f0da)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@serhiy-storchaka serhiy-storchaka removed their assignment Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants