New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] gh-93744: Remove configure --with-cxx-main option #94063
Conversation
Remove "configure --with-cxx-main" option: it didn't work for many years. Remove the following configure and Makefile variables: CXX, LDCXXSHARED, MAINCC. * MAINCC was added by issue gh-42471: commit 0f48d98. Previously, --with-cxx-main was named --with-cxx. * LDCXXSHARED was added by issue gh-42093: commit 0000295. * CXX variable was used by MAINCC and LDCXXSHARED variables.
The main change of this PR is that I'm not sure about removing the
Can distutils, setuptools and pip expect the
|
The Makefile values are included in sysconfig data file and are available through |
@@ -807,62 +804,6 @@ rm -f conftest.c conftest.out | |||
# _POSIX_SOURCE, _POSIX_1_SOURCE, and more | |||
AC_USE_SYSTEM_EXTENSIONS | |||
|
|||
AC_SUBST(CXX) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makesetup
and final Makefile
rely on CXX
variable.
It seems like removing CXX is dangerous: it seems to be used, so it would be safer... to just keep it, just in case of doubt :-) MAINCC and LDCXXSHARED don't seem to be used outside Python itself.
I ran a code search in the pypa GitHub organization:
Yep, as I wrote. makesetup:
Python Git repository has no file with extensions: .cc, .c++, .C, .cxx. There are a few files with .cpp extensions:
I only see "CXX" at one line in the final Makefile: "CXX='$(CXX)'", does it copy the environment variable or the Makefile variable?
|
It copies the Makefile variable BTW, what did you conclude here? The cxx stuff stays? |
I'm not brave. I abandon this PR and I wrote PR #95651 instead which only removes the MAINCC variables but keeps unused CXX and LDCXXSHARED variables. |
Remove "configure --with-cxx-main" option: it didn't work for many
years. Remove the following configure and Makefile variables: CXX,
LDCXXSHARED, MAINCC.
commit 0f48d98.
Previously, --with-cxx-main was named --with-cxx.
commit 0000295.