GH-91409: Don't overwrite valid locations with NOP locations
#95067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandtbucher
added
type-bug
iritkatriel
approved these changes
Jul 20, 2022
|
Thanks @brandtbucher for the PR |
|
Sorry, @brandtbucher, I could not cleanly backport this to |
brandtbucher
added a commit
to brandtbucher/cpython
that referenced
this pull request
Jul 20, 2022
…ions (pythonGH-95067). (cherry picked from commit 742d461) Co-authored-by: Brandt Bucher <brandtbucher@microsoft.com>
|
GH-95068 is a backport of this pull request to the 3.11 branch. |
brandtbucher
added a commit
that referenced
this pull request
Jul 20, 2022
|
The test seems to introduce a syntax warning while compiling below code in subtest import abc, dis
import ast as art
abc = None
dix = dis
ast = art
def f():
[dis]() # syntax warning on this line |
|
@tirkarthi Thank, I've created #96277. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
If a
NOPis followed by a "real" instruction with the same line number, don't overwrite the instruction's location with theNOP's location. That only makes sense if the instruction has no location at all.