Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure the position information in AST nodes created by the parser is always consistent #93351

Closed
pablogsal opened this issue May 30, 2022 · 2 comments · Fixed by #93352
Closed

Ensure the position information in AST nodes created by the parser is always consistent #93351

pablogsal opened this issue May 30, 2022 · 2 comments · Fixed by #93352
Labels
3.10 3.11 3.12 interpreter-core

Comments

@pablogsal
Copy link
Member

@pablogsal pablogsal commented May 30, 2022

If we create an AST node with invalid position information, the error is reported in the compiler when it validates the line numbers and end line numbers, which is too far away and debugging this can be quite challenging. To improve the debugging experience, ensure that the parser cannot create an AST node with invalid position information.
@pablogsal pablogsal mentioned this issue May 30, 2022
Merged
pablogsal added a commit to pablogsal/cpython that referenced this issue May 30, 2022
@pablogsal
pythongh-93351: Ensure the position information in AST nodes created …
6427d3f 
…by the parser is always consistent
@AA-Turner AA-Turner added interpreter-core 3.11 3.10 3.12 labels May 30, 2022
pablogsal added a commit to pablogsal/cpython that referenced this issue May 30, 2022
@pablogsal
pythongh-93351: Ensure the position information in AST nodes created …
7e04d15 
…by the parser is always consistent
pablogsal added a commit to pablogsal/cpython that referenced this issue May 30, 2022
@pablogsal
pythongh-93351: Validate the position information when compiling AST …
842049d 
…nodes
pablogsal added a commit to pablogsal/cpython that referenced this issue May 30, 2022
@pablogsal
pythongh-93351: Validate the position information when compiling AST …
dde7b64 
…nodes
pablogsal added a commit to pablogsal/cpython that referenced this issue May 30, 2022
@pablogsal
fixup! pythongh-93351: Validate the position information when compili…
20731eb 
…ng AST nodes
pablogsal added a commit to pablogsal/cpython that referenced this issue May 30, 2022
@pablogsal
fixup! pythongh-93351: Validate the position information when compili…
8d865bf 
…ng AST nodes
pablogsal added a commit that referenced this issue May 30, 2022
@pablogsal
gh-93351: Ensure the position information in AST nodes created by the…
5893b5d 
… parser is always consistent (GH-93352)
miss-islington pushed a commit to miss-islington/cpython that referenced this issue May 30, 2022
@pablogsal @miss-islington
pythongh-93351: Ensure the position information in AST nodes created …
9311b89 
…by the parser is always consistent (pythonGH-93352)

(cherry picked from commit 5893b5d)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
miss-islington added a commit that referenced this issue May 30, 2022
@miss-islington @pablogsal
gh-93351: Ensure the position information in AST nodes created by the…
7f6e6ab 
… parser is always consistent (GH-93352)

(cherry picked from commit 5893b5d)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
@hauntsaninja
Copy link
Contributor

@hauntsaninja hauntsaninja commented Jul 23, 2022

This broke a project of mine https://github.com/hauntsaninja/pyp that does some AST tricks. Worth adding a news entry (possibly to Python 3.11 What's New as well)?

@pablogsal
Copy link
Member Author

@pablogsal pablogsal commented Jul 23, 2022

I will add a news entry for this

@bedevere-bot bedevere-bot mentioned this issue Jul 23, 2022
Merged
pablogsal added a commit to pablogsal/cpython that referenced this issue Jul 23, 2022
@pablogsal
pythongh-93351: Add news entry and what's new entry for changes in py…
b3754e7 
…thongh-93351
@pablogsal pablogsal mentioned this issue Jul 23, 2022
Open
pablogsal added a commit to pablogsal/cpython that referenced this issue Jul 23, 2022
@pablogsal
pythongh-93351: Add news entry and what's new entry for changes in py…
35c568d 
…thongh-93351
pablogsal added a commit that referenced this issue Jul 23, 2022
@pablogsal
gh-93351: Add news entry and what's new entry for changes in gh-93351 (…
9762572 
…#95175)
@bedevere-bot bedevere-bot mentioned this issue Jul 23, 2022
Open
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jul 23, 2022
@pablogsal @miss-islington
pythongh-93351: Add news entry and what's new entry for changes in py…
02bac98 
…thongh-93351 (pythonGH-95175)

(cherry picked from commit 9762572d0aa3569ba82eeceb708ddea9f12918fd)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jul 23, 2022
@pablogsal @miss-islington
pythongh-93351: Add news entry and what's new entry for changes in py…
0625b33 
…thongh-93351 (pythonGH-95175)

(cherry picked from commit 9762572)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
pablogsal added a commit to pablogsal/cpython that referenced this issue Jul 23, 2022
@pablogsal
[3.11] pythongh-93351: Add news entry and what's new entry for change…
9361609 
…s in pythongh-93351 (pythonGH-95175)

(cherry picked from commit 9762572)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
@bedevere-bot bedevere-bot mentioned this issue Jul 23, 2022
Merged
pablogsal added a commit that referenced this issue Jul 23, 2022
@pablogsal
[3.11] gh-93351: Add news entry and what's new entry for changes in g…
e8edbda 
…h-93351 (GH-95175) (#95178)

(cherry picked from commit 9762572)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.10 3.11 3.12 interpreter-core
Projects
None yet
Milestone
No milestone
3 participants
@AA-Turner @pablogsal @hauntsaninja