Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[trivial] Update Python Folder.icns icon file to match new macOS look #1780

Merged
merged 1 commit into from May 17, 2018
Merged

[trivial] Update Python Folder.icns icon file to match new macOS look #1780

merged 1 commit into from May 17, 2018

Conversation

tjone270
Copy link

@tjone270 tjone270 commented May 23, 2017

The current Python Folder.icns icon is designed for Mac OS X versions
10.0 to 10.4. My new version is updated for the latest macOS version
(10.12 Sierra), and a few versions previous to 10.12.

Update Python Folder.icns icon file to match new macOS look
dc1e7bf 
The current Python Folder.icns icon is designed for Mac OS X versions
10.0 to 10.4. My new version is updated for the latest macOS version
(10.12 Sierra), and a few versions previous to 10.12.
@tjone270
Copy link
Author

tjone270 commented May 23, 2017 •
edited

Attached is a more readable PNG version of the new icon.
pythonfolder

And the old one is here:
pythonfolderold

@tjone270 tjone270 changed the title Update Python Folder.icns icon file to match new macOS look [trivial] Update Python Folder.icns icon file to match new macOS look May 24, 2017
@brettcannon brettcannon requested a review from ned-deily May 25, 2017
@tjone270
Copy link
Author

tjone270 commented May 17, 2018

Hi there,

Is there any follow-up on this pr?

@ned-deily ned-deily merged commit 74fc9c0 into python:master May 17, 2018
3 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented May 17, 2018

Thanks @tjone270 for the PR, and @ned-deily for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this issue May 17, 2018
@miss-islington
Update Python Folder.icns icon file to match new macOS look (pythonGH…
89c49f7 
…-1780)

Patch by Thomas Jones.
(cherry picked from commit 74fc9c0)

Co-authored-by: Thomas Jones <thomas@tomtecsolutions.com>
@bedevere-bot
Copy link

bedevere-bot commented May 17, 2018

GH-6930 is a backport of this pull request to the 3.7 branch.

@ned-deily
Copy link
Member

ned-deily commented May 17, 2018

Thanks, @tjone270! It looks nice!

ned-deily pushed a commit that referenced this issue May 17, 2018
@miss-islington @ned-deily
Update Python Folder.icns icon file to match new macOS look (GH-1780) (…
54a5247 
…GH-6930)

(cherry picked from commit 74fc9c0)

Co-authored-by: Thomas Jones <thomas@tomtecsolutions.com>
yahya-abou-imran pushed a commit to yahya-abou-imran/cpython that referenced this issue Nov 2, 2018
@yahya-abou-imran
Update Python Folder.icns icon file to match new macOS look (pythonGH…
fb62955 
…-1780)

Patch by Thomas Jones.
@ned-deily ned-deily mentioned this pull request Apr 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ned-deily ned-deily

Assignees
No one assigned
Labels
skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@tjone270 @miss-islington @bedevere-bot @ned-deily @brettcannon @the-knights-who-say-ni