Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-93939: Use new MODULE_name_STATE in wasm_assets script #95035

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

gh-93939: Use new MODULE_name_STATE in wasm_assets script #95035

wants to merge 1 commit into from
+6 −7

Conversation

tiran
Copy link
Member

@tiran tiran commented Jul 20, 2022 •
edited by bedevere-bot

wasm_assets.py was using the old MODULE_name variable to detect
if a shared extension is available. Emscripten browser builds now
correctly detect that e.g. json module is available.

@tiran
pythongh-93939: Use new MODULE_name_STATE in wasm_assets script
346999e 
``wasm_assets.py`` was using the old ``MODULE_name`` variable to detect
if a shared extension is available. Emscripten browser builds now
correctly detect that e.g. ``json`` module is available.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
awaiting core review needs backport to 3.11
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tiran @bedevere-bot