New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-95041: Fail syslog.syslog in case inner call to syslog.openlog fails #95264
gh-95041: Fail syslog.syslog in case inner call to syslog.openlog fails #95264
Conversation
noamcohen97
commented
Jul 26, 2022
•
edited by bedevere-bot
edited by bedevere-bot
- Issue: syslog issues #95041
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
7c6e493
to
b9307e9
Compare
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
b9307e9
to
8210ab3
Compare
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
9a20c80
to
9813348
Compare
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
The only remaining issue, is that I'd like a NEWS entry that covers both this PR and Serhiy's PR. I don't think fixing this qualifies for skip news. Serhiy? |
At first I thought that these are rather theoretical bugs that do not manifest themselves in the real world, or the effect of which is insignificant. Later I realized that it is possible that these bugs can lead to a crash if |
Ok, I'm fine with that. Let's land this :) |
Thanks @noamcohen97 for the PR, and @serhiy-storchaka for merging it |
Sorry @noamcohen97 and @serhiy-storchaka, I had trouble checking out the |
…og fails (pythonGH-95264) (cherry picked from commit b1f648e) Co-authored-by: Noam Cohen <noam@noam.me>
GH-95275 is a backport of this pull request to the 3.10 branch. |
Thanks @noamcohen97 for the PR, and @serhiy-storchaka for merging it |
GH-95277 is a backport of this pull request to the 3.11 branch. |
…og fails (pythonGH-95264) (cherry picked from commit b1f648e) Co-authored-by: Noam Cohen <noam@noam.me>
|
The failure in |