gh-95087: Fix IndexError in parsing invalid date in the email module #95201
+60
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…odule Co-authored-by: wouter bolsterlee <wouter@bolsterl.ee>
serhiy-storchaka
added
type-bug
corona10
reviewed
Jul 24, 2022
| @@ -95,6 +95,8 @@ def _parsedate_tz(data): | |||
| return None | |||
| data = data[:5] | |||
| [dd, mm, yy, tm, tz] = data | |||
| if not (dd and mm and yy): | |||
There was a problem hiding this comment.
nit?
Suggested change
| if not (dd and mm and yy): | |
| if not all((dd, mm, yy)): |
There was a problem hiding this comment.
It looks less clear to me (and it is also slower). Do you write sum((dd, mm, yy)) instead of dd + mm + yy?
warsaw
approved these changes
Jul 24, 2022
+1 for @corona10 's suggestion, but either way is probably fine. As an @python/email-team member, I'll approve and let you decide.
|
Thanks @serhiy-storchaka for the PR |
|
GH-95227 is a backport of this pull request to the 3.11 branch. |
|
GH-95228 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this issue
Jul 25, 2022
…odule (pythonGH-95201) Co-authored-by: wouter bolsterlee <wouter@bolsterl.ee> (cherry picked from commit ea5ed0ba51c10cfdde7651a475438551964dfdfc) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this issue
Jul 25, 2022
…odule (pythonGH-95201) Co-authored-by: wouter bolsterlee <wouter@bolsterl.ee> (cherry picked from commit ea5ed0ba51c10cfdde7651a475438551964dfdfc) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington
added a commit
that referenced
this issue
Jul 25, 2022
miss-islington
added a commit
that referenced
this issue
Jul 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Co-authored-by: wouter bolsterlee wouter@bolsterl.ee