Skip to content

Remove .gitignore file from dist package #47079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 29, 2022
Merged

Remove .gitignore file from dist package #47079

merged 1 commit into from
Jul 29, 2022

Conversation

cedric-anne
Copy link
Contributor

Q A
Branch? 6.2
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

Not a big deal, but .gitignore file is present in dist package fetched from packagist.

@carsonbot carsonbot added this to the 6.2 milestone Jul 27, 2022
@cedric-anne
Copy link
Contributor Author

Sorry for the multiple commits, I have made it one by one from GitHub UI. I can squash them if it is a problem.

GromNaN
GromNaN approved these changes Jul 27, 2022
View reviewed changes
Copy link
Member

@GromNaN GromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the multiple commits, I have made it one by one from GitHub UI. I can squash them if it is a problem.

Don't worry, we have a tool to squash before merging.

@nicolas-grekas
Copy link
Member

There are more of them:

src/Symfony/Contracts/Cache/.gitignore
src/Symfony/Contracts/.gitignore
src/Symfony/Contracts/EventDispatcher/.gitignore
src/Symfony/Contracts/Service/.gitignore
src/Symfony/Contracts/Translation/.gitignore
src/Symfony/Contracts/Deprecation/.gitignore
src/Symfony/Contracts/HttpClient/.gitignore

@cedric-anne
Copy link
Contributor Author

I added .gitattributes files where they were missing, and also added export-ignore on test files.
By the way, I noticed that some the namespace of test files is sometimes Test on Symfony\Contracts, and that is not consistent with namespace Tests used everywhere else in Symfony codebase.

@cedric-anne
Copy link
Contributor Author

By the way, I noticed that some the namespace of test files is sometimes Test on Symfony\Contracts, and that is not consistent with namespace Tests used everywhere else in Symfony codebase.

My bad, these should not be excluded.

fabpot
fabpot requested changes Jul 29, 2022
View reviewed changes
@nicolas-grekas
Copy link
Member

Thank you @cedric-anne.

@nicolas-grekas nicolas-grekas merged commit deacca8 into symfony:6.2 Jul 29, 2022
@cedric-anne cedric-anne deleted the patch-1 branch July 29, 2022 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot requested changes

@GromNaN GromNaN GromNaN approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
6.2
Development

Successfully merging this pull request may close these issues.
5 participants
@cedric-anne @nicolas-grekas @fabpot @GromNaN @carsonbot