Skip to content

Fix cast to null #4485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 14, 2022
Merged

Fix cast to null #4485

merged 2 commits into from
Jun 14, 2022

Conversation

lhoestq
Copy link
Member

@lhoestq lhoestq commented Jun 13, 2022

It currently fails with ArrowNotImplementedError instead of TypeError when one tries to cast integer to null type.

Because if this, type inference breaks when one replaces null values with integers in map (it first tries to cast to the previous type before inferring the new type).

Fix #4483

@lhoestq lhoestq requested a review from mariosasko June 13, 2022 13:44
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jun 13, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@mariosasko mariosasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@lhoestq lhoestq merged commit 8aef9e8 into master Jun 14, 2022
@lhoestq lhoestq deleted the fix-cast-to-null branch June 14, 2022 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dataset.map throws pyarrow.lib.ArrowNotImplementedError when converting from list of empty lists
3 participants