Skip to content

Update download url and improve card of cats_vs_dogs dataset #4523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 21, 2022

Conversation

mariosasko
Copy link
Collaborator

Improve the download URL (reported here: https://huggingface.co/datasets/cats_vs_dogs/discussions/1), remove the image_file_path column (not used in Transformers, so it should be safe) and add more info to the card.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jun 17, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ! I couldn't find any use of the image_file_path field either. I think it's fine to remove it since most image datasets don't have it anyway

@mariosasko mariosasko merged commit f561c53 into master Jun 21, 2022
@mariosasko mariosasko deleted the update-dl-url-cats_vs_dogs branch June 21, 2022 14:13
khushmeeet pushed a commit to khushmeeet/datasets that referenced this pull request Jun 23, 2022
…ngface#4523)

* Update dl url and remove file path info

* Update infos

* Improve card
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants