Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-45399: Remove hostflags from PySSLContext #28602

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

bpo-45399: Remove hostflags from PySSLContext #28602

wants to merge 6 commits into from

Conversation

ramikg
Copy link

@ramikg ramikg commented Sep 28, 2021 •
edited

The PySSLContext struct in Modules/_ssl.c mentions that "OpenSSL has no API to get hostflags from X509_VERIFY_PARAM* struct. We have to maintain our own copy".
Since OpenSSL 1.1.0i added the function X509_VERIFY_PARAM_get_hostflags, this statement is no longer true.
Because Python 3.10 requires OpenSSL 1.1.1 (PEP 644), we no longer have to maintain a copy of the host flags.

This PR removes the hostflags member from the PySSLContext struct.

Note:

  • This PR also amends a minor typo in the ssl module docs, correctly specifying that bpo43522 was fixed in OpenSSL 1.1.1l (and not 1.1.1k as in the docs).

https://bugs.python.org/issue45399

@ramikg ramikg changed the title Remove hostflags from PySSLContext bpo-43669: Remove hostflags from PySSLContext Oct 7, 2021
tiran
tiran requested changes Oct 7, 2021
View changes
Copy link
Member

@tiran tiran left a comment

bpo-43669 is closed. This PR needs a new ticket.

@bedevere-bot
Copy link

bedevere-bot commented Oct 7, 2021

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@ramikg
Copy link
Author

ramikg commented Oct 7, 2021

bpo-43669 is closed. This PR needs a new ticket.

Is it possible to submit this PR without a bpo? (on the count of it being trivial)

@tiran
Copy link
Member

tiran commented Oct 7, 2021

bpo-43669 is closed. This PR needs a new ticket.

Is it possible to submit this PR without a bpo? (on the count of it being trivial)

No, this is not a trivial change. Python requires a ticket for every change that has even a remote chance of affecting a single user. By definition, C and OpenSSL are not trivial, too.

@ramikg ramikg changed the title bpo-43669: Remove hostflags from PySSLContext bpo-45399: Remove hostflags from PySSLContext Oct 7, 2021
@ramikg
Copy link
Author

ramikg commented Oct 7, 2021 •
edited

Understood, thank you.

@ramikg ramikg requested a review from tiran May 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiran tiran

Assignees
No one assigned
Labels
awaiting changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ramikg @bedevere-bot @tiran @the-knights-who-say-ni @ezio-melotti