Skip to content

gh-76002: asyncio: allow pause_reading() from connection_made() #4053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

gh-76002: asyncio: allow pause_reading() from connection_made() #4053

wants to merge 2 commits into from

Conversation

pitrou
Copy link
Member

@pitrou pitrou commented Oct 19, 2017 •
edited by AlexWaygood
Loading

@pitrou pitrou requested a review from 1st1 as a code owner October 19, 2017 18:53
@pitrou pitrou added needs backport to 3.6 type-bug An unexpected behavior, bug, or error awaiting merge and removed awaiting merge labels Oct 19, 2017
@1st1
Copy link
Member

1st1 commented Oct 19, 2017

Hm. We'll need to run tests from the uvloop (has more functional tests) project with this patch.

@1st1
Copy link
Member

1st1 commented Oct 19, 2017

But I like the change. Let me think about it for a few days.

@pitrou
Copy link
Member Author

pitrou commented Oct 19, 2017

No pb!

@pitrou
Copy link
Member Author

pitrou commented Dec 21, 2017

@1st1 any update here?

asvetlov
asvetlov reviewed Dec 21, 2017
View reviewed changes
Lib/asyncio/selector_events.py
self._loop.call_soon(self._loop._add_reader,
self._sock_fd, self._read_ready)
if waiter is not None:
def _call_connection_made():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Convert nested function into instance method maybe?

@asvetlov
Copy link
Contributor

I like the PR but the came approach should be added to all transports (SSL and pipes) IMHO.

@vstinner
Copy link
Member

I removed the " needs backport to 3.6" label, the 3.6 branch no longer accept bugfixes (only security fixes are accepted): https://devguide.python.org/#status-of-python-branches

@csabella csabella mentioned this pull request Dec 15, 2019
Merged
@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Mar 17, 2022
@pitrou pitrou mentioned this pull request Apr 10, 2022
Closed
@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Jul 29, 2022
@github-actions
Copy link

github-actions bot commented Dec 8, 2022

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Dec 8, 2022
@AlexWaygood AlexWaygood changed the title bpo-31821: allow pause_reading() from connection_made() gh-76002: allow pause_reading() from connection_made() Dec 8, 2022
@AlexWaygood AlexWaygood changed the title gh-76002: allow pause_reading() from connection_made() gh-76002: asyncio: allow pause_reading() from connection_made() Dec 8, 2022
@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Dec 9, 2022
kumaraditya303
kumaraditya303 requested changes Dec 10, 2022
View reviewed changes
Copy link
Contributor

@kumaraditya303 kumaraditya303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are merge conflicts.

@bedevere-bot
Copy link

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Jan 10, 2023
@kumaraditya303
Copy link
Contributor

Closing as there are merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvetlov asvetlov asvetlov left review comments

@kumaraditya303 kumaraditya303 kumaraditya303 requested changes

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

Assignees
No one assigned
Labels
awaiting changes stale Stale PR or inactive for long period of time. topic-asyncio type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.