Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-95376: Add test for names containing null #95394

Merged
merged 2 commits into from Aug 6, 2022
Merged

gh-95376: Add test for names containing null #95394

merged 2 commits into from Aug 6, 2022

Conversation

Yaminyam
Copy link
Contributor

@Yaminyam Yaminyam commented Jul 28, 2022 •
edited by bedevere-bot

In grp, a module similar to pwd, it tests the case that the name value contains null, but pwd does not test it, so it was added.

@cpython-cla-bot
Copy link

cpython-cla-bot bot commented Jul 28, 2022 •
edited

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-bot
Copy link

bedevere-bot commented Jul 28, 2022

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label Jul 28, 2022
@Yaminyam Yaminyam mentioned this pull request Jul 28, 2022
Merged
mdboom
mdboom approved these changes Jul 29, 2022
View changes
Copy link
Contributor

@mdboom mdboom left a comment

LGTM

erlend-aasland
erlend-aasland reviewed Jul 31, 2022
View changes
Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

While you're at it, can you see if you can get coverage for the else clause of sets() also? Apart from that, the uncovered rest seems to be mostly memory errors.

Lib/test/test_pwd.py Outdated Show resolved Hide resolved
@Yaminyam Yaminyam mentioned this pull request Aug 1, 2022
Merged
@ambv ambv merged commit a17cd47 into python:main Aug 6, 2022
12 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Aug 6, 2022

Thanks @Yaminyam for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erlend-aasland erlend-aasland

@mdboom mdboom

@kumaraditya303 kumaraditya303

Assignees
No one assigned
Labels
needs backport to 3.10 needs backport to 3.11 skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@Yaminyam @bedevere-bot @miss-islington @mdboom @erlend-aasland @kumaraditya303 @ambv