[Console] get full command path for command in search path #47022
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Notice: I also think the -f (file) should be replaced by -x (executable) |
carsonbot
changed the title
|
Notice (but this is another issue), that alias case may be broken if contains options, |
Seldaek
approved these changes
Jul 22, 2022
|
cc @wouterj too as he did the original implementation. |
chalasr
approved these changes
Jul 22, 2022
GromNaN
approved these changes
Jul 22, 2022
|
Two confirmations it works with this patch applied: composer/composer#10961 |
fabpot
approved these changes
Jul 22, 2022
|
Thank you @remicollet. |
This was referenced Jul 29, 2022
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Working on composer 2.4.0RC1 will autocompletion
When the command is in the search path, -f fails, so we need to switch to its full path