Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Serializer] fix(serializer): missing empty_array_as_object in example #16977

Merged
merged 1 commit into from Aug 8, 2022
Merged

[Serializer] fix(serializer): missing empty_array_as_object in example #16977

merged 1 commit into from Aug 8, 2022
+5 −2

Conversation

alanpoulain
Copy link
Contributor

@alanpoulain alanpoulain commented Jul 13, 2022 •
edited

This PR:

  • Replaces empty_iterable_as_object by preserve_empty_objects, like it should be.
  • Adds empty_array_as_object to example in Serializer Context.
  • Removes the mention by default, since it's false by default.

Related:

@carsonbot carsonbot added this to the 5.4 milestone Jul 13, 2022
@carsonbot carsonbot changed the title fix(serializer): missing empty_array_as_object in example [Serializer] fix(serializer): missing empty_array_as_object in example Aug 8, 2022
@javiereguiluz
Copy link
Member

@javiereguiluz javiereguiluz commented Aug 8, 2022

Thank you Alan.

@javiereguiluz javiereguiluz merged commit 90ff119 into symfony:5.4 Aug 8, 2022
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Serializer Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alanpoulain @javiereguiluz @carsonbot