Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-95573: Reduce test data size in test_asyncio/test_ssl.py #95668

Merged
merged 5 commits into from Aug 5, 2022
Merged

gh-95573: Reduce test data size in test_asyncio/test_ssl.py #95668

merged 5 commits into from Aug 5, 2022
+18 −7

Conversation

fantix
Copy link
Contributor

@fantix fantix commented Aug 4, 2022 •
edited by bedevere-bot

The error was like:

Task exception was never retrieved
future: <Task finished name='Task-79' coro=<TestSSL.test_create_server_ssl_over_ssl.<locals>.handle_client() done, defined at cpython/Lib/test/test_asyncio/test_ssl.py:1039> exception=OSError(55, 'No buffer space available')>
Traceback (most recent call last):
  File "cpython/Lib/test/test_asyncio/test_ssl.py", line 1042, in handle_client
    data = await reader.readexactly(len(A_DATA))
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "cpython/Lib/asyncio/streams.py", line 728, in readexactly
    await self._wait_for_data('readexactly')
  File "cpython/Lib/asyncio/streams.py", line 522, in _wait_for_data
    await self._waiter
  File "cpython/Lib/asyncio/selector_events.py", line 1049, in write
    n = self._sock.send(data)
        ^^^^^^^^^^^^^^^^^^^^^
OSError: [Errno 55] No buffer space available

It was suppressed because of this:

cpython/Lib/test/test_asyncio/test_ssl.py

Lines 1159 to 1160 in 8a0d9a6

with self._silence_eof_received_warning():
self.loop.run_until_complete(start_server())

@fantix fantix requested review from 1st1 and asvetlov as code owners Aug 4, 2022
@bedevere-bot bedevere-bot added tests awaiting review labels Aug 4, 2022
@pablogsal pablogsal added the 🔨 test-with-buildbots label Aug 4, 2022
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Aug 4, 2022

🤖 New build scheduled with the buildbot fleet by @pablogsal for commit 4284913 🤖

If you want to schedule another build, you need to add the "🔨 test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots label Aug 4, 2022
@ambv
Copy link
Contributor

@ambv ambv commented Aug 5, 2022

Note: all tests with buildbots pass here with 4284913. The red x is due to missing Misc/NEWS, which I fixed now. Additionally, as discussed on GH-95573, I made the smaller buffer only apply on macOS.

@ambv ambv merged commit 3a9e1fd into python:main Aug 5, 2022
15 checks passed
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Aug 5, 2022

Thanks @fantix for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Aug 5, 2022

GH-95705 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this issue Aug 5, 2022
@fantix @miss-islington
pythongh-95573: Reduce test data size in test_asyncio/test_ssl.py (py…
1e3d3e5 
…thonGH-95668)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
(cherry picked from commit 3a9e1fd)

Co-authored-by: Fantix King <fantix.king@gmail.com>
ambv pushed a commit that referenced this issue Aug 5, 2022
@miss-islington @fantix
gh-95573: Reduce test data size in test_asyncio/test_ssl.py (GH-95668) (
954b887 
GH-95705)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
(cherry picked from commit 3a9e1fd)

Co-authored-by: Fantix King <fantix.king@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1st1 1st1

@asvetlov asvetlov

Assignees
No one assigned
Labels
tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@fantix @bedevere-bot @ambv @miss-islington @pablogsal