Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tools/c-analyzer is out-of-date. #90110

Closed
ericsnowcurrently opened this issue Dec 1, 2021 · 4 comments
Closed

Tools/c-analyzer is out-of-date. #90110

ericsnowcurrently opened this issue Dec 1, 2021 · 4 comments
Assignees
@ericsnowcurrently
Labels
3.11 type-bug An unexpected behavior, bug, or error

Comments

@ericsnowcurrently
Copy link
Member

ericsnowcurrently commented Dec 1, 2021 •
edited by bedevere-bot

BPO 45952
Nosy @ericsnowcurrently
PRs
  • bpo-45952: Get the C analyzer tool working again. #29882
  • bpo-45952: Get the C analyzer tool working again. #31219
  • bpo-45952: Get the C analyzer tool working again. #31220
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/ericsnowcurrently'
closed_at = <Date 2021-12-01.18:20:52.798>
created_at = <Date 2021-12-01.17:49:22.763>
labels = ['type-bug', '3.11']
title = 'Tools/c-analyzer is out-of-date.'
updated_at = <Date 2022-02-08.19:38:00.941>
user = 'https://github.com/ericsnowcurrently'

    bugs.python.org fields:

    activity = <Date 2022-02-08.19:38:00.941>
actor = 'eric.snow'
assignee = 'eric.snow'
closed = True
closed_date = <Date 2021-12-01.18:20:52.798>
closer = 'eric.snow'
components = ['Demos and Tools']
creation = <Date 2021-12-01.17:49:22.763>
creator = 'eric.snow'
dependencies = []
files = []
hgrepos = []
issue_num = 45952
keywords = []
message_count = 4.0
messages = ['407474', '407475', '412859', '412862']
nosy_count = 1.0
nosy_names = ['eric.snow']
pr_nums = ['29882', '31219', '31220']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue45952'
versions = ['Python 3.11']
    @ericsnowcurrently
    Copy link
    Member Author

    ericsnowcurrently commented Dec 1, 2021

    Some relatively recent changes broke "./python Tools/c-analyzer/c-analyzer.py ...". Also, Tools/c-analyzer/TODO is a bit out of date.

    @ericsnowcurrently ericsnowcurrently self-assigned this Dec 1, 2021
    @ericsnowcurrently ericsnowcurrently added type-bug An unexpected behavior, bug, or error 3.11 labels Dec 1, 2021
    @ericsnowcurrently ericsnowcurrently self-assigned this Dec 1, 2021
    @ericsnowcurrently ericsnowcurrently added the type-bug An unexpected behavior, bug, or error label Dec 1, 2021
    @ericsnowcurrently
    Copy link
    Member Author

    ericsnowcurrently commented Dec 1, 2021

    New changeset ee94aa0 by Eric Snow in branch 'main':
    bpo-45952: Get the C analyzer tool working again. (gh-29882)
    ee94aa0

    @ericsnowcurrently
    Copy link
    Member Author

    ericsnowcurrently commented Feb 8, 2022

    New changeset 1e6214d by Eric Snow in branch 'main':
    bpo-45952: Get the C analyzer tool working again. (gh-31219)
    1e6214d

    @ericsnowcurrently
    Copy link
    Member Author

    ericsnowcurrently commented Feb 8, 2022

    New changeset c018d30 by Eric Snow in branch 'main':
    bpo-45952: Get the C analyzer tool working again. (gh-31220)
    c018d30

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    @bedevere-bot bedevere-bot mentioned this issue Aug 1, 2022
    Merged
    ericsnowcurrently added a commit that referenced this issue Aug 1, 2022
    @ericsnowcurrently
    gh-90110: Get the C Analyzer Tool Working Again (gh-95545)
    a7161f9
    @bedevere-bot bedevere-bot mentioned this issue Aug 3, 2022
    Merged
    ericsnowcurrently added a commit that referenced this issue Aug 4, 2022
    @ericsnowcurrently
    gh-90110: Update the C Analyzer Tool Whitelists (gh-95628)
    60f54d9
    iritkatriel pushed a commit to iritkatriel/cpython that referenced this issue Aug 11, 2022
    @ericsnowcurrently @iritkatriel
    pythongh-90110: Update the C Analyzer Tool Whitelists (pythongh-95628)
    753a3ae
    @bedevere-bot bedevere-bot mentioned this issue Aug 17, 2022
    Merged
    ericsnowcurrently added a commit that referenced this issue Aug 17, 2022
    @ericsnowcurrently
    gh-90110: Get the C Analyzer Tool Working Again (gh-96057)
    5aac851 
    We broke it with a recent `_PyArg_Parser` change.

Also:
* moved the `_PyArg_Parser` whitelist entries over to ignored.tsv now that they are thread-safe
* added some known globals from a currently-excluded file
* dropped some outdated globals from the whitelist
    @bedevere-bot bedevere-bot mentioned this issue Aug 17, 2022
    Merged
    ericsnowcurrently added a commit that referenced this issue Aug 17, 2022
    @ericsnowcurrently
    gh-90110: Update the c-analyzer Tool (gh-96058)
    586fc02
    tiran pushed a commit to tiran/cpython that referenced this issue Aug 19, 2022
    @ericsnowcurrently @tiran
    pythongh-90110: Get the C Analyzer Tool Working Again (pythongh-96057)
    0c8b215 
    We broke it with a recent `_PyArg_Parser` change.

Also:
* moved the `_PyArg_Parser` whitelist entries over to ignored.tsv now that they are thread-safe
* added some known globals from a currently-excluded file
* dropped some outdated globals from the whitelist
    tiran pushed a commit to tiran/cpython that referenced this issue Aug 19, 2022
    @ericsnowcurrently @tiran
    pythongh-90110: Update the c-analyzer Tool (pythongh-96058)
    e60f1a9
    @bedevere-bot bedevere-bot mentioned this issue Aug 25, 2022
    Merged
    ericsnowcurrently added a commit that referenced this issue Aug 25, 2022
    @ericsnowcurrently
    gh-90110: Update the c-analyzer Tool (gh-96255)
    d45d5c2 
    Here we automatically ignore uses of _PyArg_Parser, "kwlist" arrays, and module/type defs. That way new uses don't trigger false positives in the c-analyzer check script.
    @bedevere-bot bedevere-bot mentioned this issue Sep 10, 2022
    Merged
    ericsnowcurrently added a commit that referenced this issue Sep 12, 2022
    @ericsnowcurrently
    gh-90110: Fix the c-analyzer Tool (gh-96731)
    1756ffd 
    This includes:

* update the whitelists
* fixes so we can stop ignoring some of the files
* ensure Include/cpython/*.h get analyzed
    @bedevere-bot bedevere-bot mentioned this issue Sep 30, 2022
    Merged
    ericsnowcurrently added a commit that referenced this issue Oct 1, 2022
    @ericsnowcurrently
    gh-90110: Update the c-analyzer Tool (gh-97695)
    273a819 
    #90110
    serhiy-storchaka pushed a commit to serhiy-storchaka/cpython that referenced this issue Oct 2, 2022
    @ericsnowcurrently @serhiy-storchaka
    pythongh-90110: Update the c-analyzer Tool (pythongh-97695)
    4c95e50 
    python#90110
    @bedevere-bot bedevere-bot mentioned this issue Nov 10, 2022
    Merged
    ericsnowcurrently added a commit that referenced this issue Nov 10, 2022
    @ericsnowcurrently
    gh-90110: Update the C-analyzer Tool (gh-99307)
    73679b1
    gvanrossum pushed a commit to gvanrossum/cpython that referenced this issue Nov 10, 2022
    @ericsnowcurrently @gvanrossum
    pythongh-90110: Update the C-analyzer Tool (pythongh-99307)
    e0ab5b8
    ethanfurman pushed a commit to ethanfurman/cpython that referenced this issue Nov 12, 2022
    @ericsnowcurrently @ethanfurman
    pythongh-90110: Update the C-analyzer Tool (pythongh-99307)
    d5fa9c6
    @bedevere-bot bedevere-bot mentioned this issue Dec 7, 2022
    Merged
    ericsnowcurrently added a commit that referenced this issue Dec 7, 2022
    @ericsnowcurrently
    gh-90110: Clean Up the C-analyzer Globals Lists (gh-100091)
    d47ffeb 
    #90110
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @ericsnowcurrently ericsnowcurrently

    Labels
    3.11 type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @ericsnowcurrently and others