Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xml.etree.ElementTree — doesn't allow specifying fine-grained formatting controls #95472

Open
ctrlcctrlv opened this issue Jul 30, 2022 · 0 comments · May be fixed by #95476
Open

xml.etree.ElementTree — doesn't allow specifying fine-grained formatting controls #95472

ctrlcctrlv opened this issue Jul 30, 2022 · 0 comments · May be fixed by #95476
Labels
type-feature

Comments

@ctrlcctrlv
Copy link

@ctrlcctrlv ctrlcctrlv commented Jul 30, 2022 •
edited

(Note: I already have a PR and this is a tracking issue.)

Enhancement

XML is maddening from a Git perspective, as if multiple tools will edit it, you'll get lots of lines in the diff that aren't needed.

For example:

diff --git a/sources/designspace/Besley.designspace b/sources/designspace/Besley.designspace
index d247944..eecb985 100644
--- a/sources/designspace/Besley.designspace
+++ b/sources/designspace/Besley.designspace
@@ -1,4 +1,4 @@
-<?xml version="1.0" encoding="UTF-8"?>
+<?xml version='1.0' encoding='UTF-8'?>

And:

diff --git a/sources/designspace/Besley.designspace b/sources/designspace/Besley.designspace
index d247944..9d570dd 100644
--- a/sources/designspace/Besley.designspace
+++ b/sources/designspace/Besley.designspace
@@ -1,4 +1,4 @@
-<?xml version="1.0" encoding="UTF-8"?>
+<?xml version='1.0' encoding='UTF-8'?>
 <designspace format="4.1">
 
   <axes>
@@ -10,15 +10,15 @@
       <map input="800" output="766"/>
       <map input="900" output="900"/>
     </axis>
-    <axis tag="wdth" name="Width" minimum="75" maximum="100" default="100"></axis>
+    <axis tag="wdth" name="Width" minimum="75" maximum="100" default="100" />
   </axes>
 
   <sources>
 
     <source filename="../ufo/Besley-Book.ufo" name="Besley Regular" familyname="Besley" stylename="Regular">
       <location>
-        <dimension name="Weight" xvalue="400"/>
-        <dimension name="Width" xvalue="100"/>
+        <dimension name="Weight" xvalue="400" />
+        <dimension name="Width" xvalue="100" />
       </location>
     </source>

There are likely other issues, but I only needed to solve these two.
@ctrlcctrlv ctrlcctrlv added the type-feature label Jul 30, 2022
@ctrlcctrlv ctrlcctrlv linked a pull request Jul 30, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-95472: [xml.etree.ElementTree] Add fine-grained formatting classes ctrlcctrlv/cpython
1 participant
@ctrlcctrlv