Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document 3.13, 3.14, 4.0 and future removals #93986

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Jun 18, 2022

Follow on from #92308.

This lists in the What's New page some more deprecations pending removal in:

@warsaw
Copy link
Member

warsaw commented Jun 18, 2022

I wonder if there was some automation we can add to help ensure that planned deprecations actually happen? Like, maybe a JSON file or some such where the deprecations are recorded (or a script to parse the docs or code). Then, when the new version is created at main, the automation would open some release blockers on those deprecations. What do you think?

@arhadthedev
Copy link
Contributor

arhadthedev commented Jun 18, 2022

@warsaw Probably, grepping docs for .. deprecated-removed:: and headers for Py_DEPRECATED would be better than maintaining another list file.

Edit: for \.\. deprecated-removed:: [^ ]+ (\d+).(\d+) and Py_DEPRECATED\((\d+).(\d+)\).

@hugovk
Copy link
Member Author

hugovk commented Jun 19, 2022

I wonder if there was some automation we can add to help ensure that planned deprecations actually happen?

Yes, using the new warnings._deprecated method will make it clear with RuntimeErrors after the relevant alpha: https://discuss.python.org/t/introducing-warnings-deprecated/14856

Doc/whatsnew/3.12.rst Outdated Show resolved Hide resolved
@ezio-melotti
Copy link
Member

ezio-melotti commented Jul 29, 2022

I wonder if there was some automation we can add to help ensure that planned deprecations actually happen?

See also:

Copy link
Member

@ezio-melotti ezio-melotti left a comment

I left a comment and a couple of minor suggestions -- feel free to disregard them if you think the current version is better.

Doc/whatsnew/3.12.rst Outdated Show resolved Hide resolved
Doc/whatsnew/3.12.rst Outdated Show resolved Hide resolved
Doc/whatsnew/3.12.rst Outdated Show resolved Hide resolved
Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
Doc/whatsnew/3.12.rst Outdated Show resolved Hide resolved
@CAM-Gerlach
Copy link
Member

CAM-Gerlach commented Aug 11, 2022

I wonder if there was some automation we can add to help ensure that planned deprecations actually happen?

You could also fire a Sphinx warning in the else branch here in the directive (with a check for whether its an alpha, and perhaps an :option: to disable it for special cases), just like warnings._deprecated does.

Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants