Skip to content

feat(net/http): provide an option to access /index.html without 301 redirect #53913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

ahuigo
Copy link

@ahuigo ahuigo commented Jul 16, 2022

For: #53870
BREAKING CHANGES: http.ServeFile won't redirect /index.html

…out 301 redirect

For: golang#53870
BREAKING CHANGES: http.ServeFile won't redirect /index.html
@google-cla
Copy link

google-cla bot commented Jul 16, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@ahuigo ahuigo closed this Jul 16, 2022
@ahuigo ahuigo force-pushed the release-branch.go1.18 branch from 56e2fa0 to 88a06f4 Compare July 16, 2022 11:10
@ahuigo ahuigo reopened this Jul 16, 2022
@gopherbot
Copy link
Contributor

This PR (HEAD: 56e2fa0) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/417914 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/417914.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Damien Neil:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/417914.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/417914 has been abandoned.

This CL (imported from a PR) is targeting the "release-branch.go1.18" branch. Go 1.18 is no longer supported per the release policy and so we don't use the release-branch.go1.18 branch for anything now.

If this is a change you'd still like to pursue after taking into account the review comment above, please see https://go.dev/doc/contribute#before_contributing and send it again making sure the target branch is named master and not one of the release branches. Thanks.

@gopherbot gopherbot closed this May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants