Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PropertyInfo] Ignore empty doc-block for promoted properties in PhpStanExtractor #46361

Merged
merged 1 commit into from May 17, 2022
Merged

[PropertyInfo] Ignore empty doc-block for promoted properties in PhpStanExtractor #46361

merged 1 commit into from May 17, 2022

Conversation

BoShurik
Copy link
Contributor

@BoShurik BoShurik commented May 16, 2022

Q A
Branch? 6.1
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR symfony/symfony-docs#...

Fix processing empty doc-block for promoted properties (introduced in #46056)

@BoShurik BoShurik requested a review from dunglas as a code owner May 16, 2022
@carsonbot carsonbot added this to the 6.1 milestone May 16, 2022
@carsonbot
Copy link

@carsonbot carsonbot commented May 17, 2022

Hey!

I think @Korbeil has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

@nicolas-grekas
Copy link
Member

@nicolas-grekas nicolas-grekas commented May 17, 2022

Thank you @BoShurik.

@nicolas-grekas nicolas-grekas merged commit 9fafd82 into symfony:6.1 May 17, 2022
6 of 9 checks passed
@fabpot fabpot mentioned this pull request May 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunglas dunglas

Assignees
No one assigned
Labels
Bug PropertyInfo Status: Needs Review
Projects
None yet
Milestone
6.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@BoShurik @carsonbot @nicolas-grekas