[Validator] Fix traverse option on Valid constraint when used as Attribute #46244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please add a test case? Note also that we cannot use mixed as 5.4 should support PHP 7.2 |
|
@nicolas-grekas Thanks for the feedback. I have removed the |
xabbuh
reviewed
May 13, 2022
xabbuh
previously approved these changes
May 18, 2022
nicolas-grekas
reviewed
May 21, 2022
nicolas-grekas
reviewed
May 21, 2022
|
@nicolas-grekas @derrabus Any progress here? |
xabbuh
approved these changes
Jul 8, 2022
fabpot
requested changes
Jul 8, 2022
HeahDude
reviewed
Jul 8, 2022
xabbuh
approved these changes
Jul 13, 2022
fabpot
approved these changes
Jul 15, 2022
|
Thank you @tobias-93. |
This was referenced Jul 29, 2022
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fix Valid constraint when using as Attribute.