[HttpKernel] Fix session initialized several times #38910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jderusse
changed the title
jderusse
changed the title
|
Could I ask you for a test too? |
jderusse
changed the title
nicolas-grekas
approved these changes
Nov 2, 2020
|
Thank you @jderusse. |
nicolas-grekas
reviewed
Nov 2, 2020
| @@ -20,11 +20,13 @@ | |||
| use Symfony\Component\HttpFoundation\Session\Session; | |||
| use Symfony\Component\HttpFoundation\Session\Storage\NativeSessionStorage; | |||
| use Symfony\Component\HttpKernel\Event\FinishRequestEvent; | |||
| use Symfony\Component\HttpKernel\Event\GetResponseEvent; | |||
There was a problem hiding this comment.
This class is deprecated, I'm fixing it in the source directly, see 76c1939
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The session injected in the request is a factory. When the request is cloned (ie sub-request) while the session is not yet used in the master request (the session is still a factory), both Master and Sub request will have a factory.
If both requests attempt to read the session afterward, they both triggers the factory, and both initialize the session.
It's not a dead end for the
SessionListenerbecause the session come from the container and is shared, but: