gh-87980: Fix the error message for disallowed __weakref__ slots #25362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When “TypeError: __weakref__ slot disallowed: either we already got one, or __itemsize__ != 0” is raised, the condition base->tp_itemsize != 0 is impossible since using a non-empty __slots__ for a subtype of a variable-length type raises a “TypeError: nonempty __slots__ not supported for subtype of '…'” earlier.
|
This PR is stale because it has been open for 30 days with no activity. |
github-actions
bot
removed
the
stale
geryogam
changed the title
kumaraditya303
approved these changes
Jan 1, 2023
|
Thanks for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
is raised, the second condition
base->tp_itemsize != 0(i.e. the base is a variable-length type, likeint,tupleandbytes) in the error message is impossible since using a non-empty__slots__(e.g.__slots__ = ('__weakref__',)) for a subtype of a variable-length type raises aearlier in the
type.__new__implementation.