Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-93243: Make smtpd private before porting its users #93246

Merged
merged 19 commits into from Aug 6, 2022
Merged

gh-93243: Make smtpd private before porting its users #93246

merged 19 commits into from Aug 6, 2022

Conversation

arhadthedev
Copy link
Contributor

@arhadthedev arhadthedev commented May 26, 2022 •
edited by miss-islington

gh-93243

This PR is required to reduce diffs of the following porting (no need to either maintain documentation and tests consistent with each porting step, or try to port everything and remove smtpd in a single PR).

Automerge-Triggered-By: GH:warsaw

@arhadthedev arhadthedev requested review from and vsajip as code owners May 26, 2022
hugovk
hugovk reviewed Jun 4, 2022
View changes
PCbuild/lib.pyproj Show resolved Hide resolved
AA-Turner
AA-Turner reviewed Jun 4, 2022
View changes
Copy link
Member

@AA-Turner AA-Turner left a comment

Some docs/wording comments:

A

Doc/whatsnew/3.12.rst Outdated Show resolved Hide resolved
Doc/whatsnew/3.12.rst Outdated Show resolved Hide resolved
Lib/test/mock_socket.py Outdated Show resolved Hide resolved
Lib/test/mock_socket.py Outdated Show resolved Hide resolved
Misc/NEWS.d/next/Library/2022-05-26-08-41-34.gh-issue-93243.uw6x5z.rst Outdated Show resolved Hide resolved
arhadthedev and others added 4 commits Jun 4, 2022
@arhadthedev @AA-Turner
Update Doc/whatsnew/3.12.rst
c7cb1e3 
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@arhadthedev @AA-Turner
Update Doc/whatsnew/3.12.rst
8180429 
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@arhadthedev @AA-Turner
Address the review of AA-Turner (using suggestion batching)
b70bf5a 
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@arhadthedev
Remove non-working :mod:
4054ac2
AA-Turner
AA-Turner reviewed Jun 4, 2022
View changes
Doc/whatsnew/3.12.rst Outdated Show resolved Hide resolved
@arhadthedev @AA-Turner
Update Doc/whatsnew/3.12.rst
eb6ad56 
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@hugovk
Copy link
Member

@hugovk hugovk commented Jun 4, 2022

cc also PEP-594 co-author @brettcannon.

brettcannon
brettcannon requested changes Jun 8, 2022
View changes
Copy link
Member

@brettcannon brettcannon left a comment

Probably need logging and email maintainers to sign off that they are okay with keeping smptd around for testing.

Lib/test/test_logging.py Show resolved Hide resolved
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jun 8, 2022

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@arhadthedev
Copy link
Contributor Author

@arhadthedev arhadthedev commented Jun 8, 2022

I have made the requested changes; please review again.

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jun 8, 2022

Thanks for making the requested changes!

@brettcannon: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from brettcannon Jun 8, 2022
@arhadthedev
Copy link
Contributor Author

@arhadthedev arhadthedev commented Jul 29, 2022 •
edited

Probably need logging and email maintainers to sign off that they are okay with keeping smptd around for testing.

@vsajip @warsaw could you review and possibly merge this PR please? It deletes smtpd tests in advance and, for consistency, makes the module private by moving it into Lib/test/smtpd.py.

This is necessary to allow further reviewable-sized PRs (one for each SMTP* class moved into its consumer in test) without massive changes of Lib/test/test_smtpd.py for synchronization.

warsaw
warsaw requested changes Aug 4, 2022
View changes
Copy link
Member

@warsaw warsaw left a comment

I have a small rewording request.

Doc/whatsnew/3.12.rst Outdated Show resolved Hide resolved
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Aug 4, 2022

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@arhadthedev
Copy link
Contributor Author

@arhadthedev arhadthedev commented Aug 4, 2022

I have made the requested changes; please review again.

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Aug 4, 2022

Thanks for making the requested changes!

@brettcannon, @warsaw: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from warsaw Aug 4, 2022
@warsaw
Update 3.12.rst
e351af3 
Wording suggestion.
@brettcannon
Copy link
Member

@brettcannon brettcannon commented Aug 5, 2022

@warsaw not sure if this is showing up in your review queue as the GH UI is not letting me re-request your review.

@warsaw
Update 3.12.rst
1d157ec 
Small reword suggestion.
@warsaw
Copy link
Member

@warsaw warsaw commented Aug 6, 2022

Thanks for the ping @brettcannon - I'm good with this, with my one edit to the source branch. I thought I'd pushed that through previously, but upon further review, it doesn't look like it stuck. Trying that again...

@warsaw warsaw added the 🤖 automerge PR will be merged once it's been approved and all CI passed label Aug 6, 2022
warsaw
warsaw approved these changes Aug 6, 2022
View changes
Copy link
Member

@warsaw warsaw left a comment

Okay, this time it looks like my small wording edit got committed. Thanks for the contribution @arhadthedev ! Approving and setting the automerge label.

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Aug 6, 2022

Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 56d16e8 into python:main Aug 6, 2022
14 checks passed
@arhadthedev arhadthedev deleted the privatize-smtpd branch Aug 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk

@AA-Turner AA-Turner

@warsaw warsaw

@python/windows-team windows-team

@vsajip vsajip

@brettcannon brettcannon

Assignees
No one assigned
Labels
🤖 automerge PR will be merged once it's been approved and all CI passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@arhadthedev @hugovk @bedevere-bot @brettcannon @warsaw @miss-islington @AA-Turner