Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-95395: Add argument type error test #95412

Merged
merged 2 commits into from Aug 6, 2022
Merged

gh-95395: Add argument type error test #95412

merged 2 commits into from Aug 6, 2022

Conversation

Yaminyam
Copy link
Contributor

@Yaminyam Yaminyam commented Jul 29, 2022

@bedevere-bot
Copy link

bedevere-bot commented Jul 29, 2022

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label Jul 29, 2022
mdboom
mdboom approved these changes Jul 29, 2022
Copy link
Contributor

@mdboom mdboom left a comment

LGTM

@Yaminyam
Copy link
Contributor Author

Yaminyam commented Aug 1, 2022

#95394 Also modified the tests in the grp module according to the discussion in that pr

@ambv ambv merged commit 4703c15 into python:main Aug 6, 2022
12 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Aug 6, 2022

Thanks @Yaminyam for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 6, 2022
(cherry picked from commit 4703c15)

Co-authored-by: Sion Kang <31057849+Yaminyam@users.noreply.github.com>
@bedevere-bot
Copy link

bedevere-bot commented Aug 6, 2022

GH-95744 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 6, 2022
(cherry picked from commit 4703c15)

Co-authored-by: Sion Kang <31057849+Yaminyam@users.noreply.github.com>
@bedevere-bot
Copy link

bedevere-bot commented Aug 6, 2022

GH-95745 is a backport of this pull request to the 3.10 branch.

ambv pushed a commit that referenced this pull request Aug 6, 2022
(cherry picked from commit 4703c15)

Co-authored-by: Sion Kang <31057849+Yaminyam@users.noreply.github.com>
ambv pushed a commit that referenced this pull request Aug 6, 2022
(cherry picked from commit 4703c15)

Co-authored-by: Sion Kang <31057849+Yaminyam@users.noreply.github.com>
iritkatriel pushed a commit to iritkatriel/cpython that referenced this pull request Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants