Please open a new issue: https://bugs.python.org/issue39828 is now closed.

Please open a new issue: https://bugs.python.org/issue39828 is now closed.

Ignore my comment. This PR was added to https://bugs.python.org/issue39828 because you used " bpo-39828" in the commit message. But you already used a new issue: https://bugs.python.org/issue42005

Actually it's not in the commit message, I only referenced bpo-39828 for context in the PR body. Sorry it accidentally confused the bot.

@vstinner Thanks for the review.

BrokenPipeError is more likely related to stdout than stderr.

Absolutely.

I understand that your intent is to ignore the warning displayed on stderr when sys.stdout file is closed.

In fact setting sys.stdout was enough to suppress the unraisable exception. I threw sys.stderr in there without much thought just in case someone has stderr closed too (say if stderr is redirected to stdout). Now I realize it's more trouble than it's worth.

Since json.tool already has a similar code pattern, maybe it would be worth it to provide a helper function somewhere. I would prefer a private function.

Are you suggesting something like

def run_with_broken_pipe_awareness(func, *args, **kwargs):
    try:
        return func(*args, **kwargs)
    except BrokenPipeError as exc:
        sys.stdout = None
        sys.exit(exc.errno)

? If I were to add such a private helper, where should I place it? I can't seem to find a place in the code base where cross-module helpers live.

By the way, it might be better to delete sys.stdout or set it to None

I erroneously thought it needs to be set to something that still supports write() or it would again cause an exception. Apparently it's not the case, corrected.

This PR is stale because it has been open for 30 days with no activity.

I rebased on top of master. Other than that I think I'm just waiting for reviewer(s).

Thanks @zmwangx for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

GH-24262 is a backport of this pull request to the 3.9 branch.

Thanks @zmwangx for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

GH-24263 is a backport of this pull request to the 3.8 branch.

Thanks @zmwangx: I tested your PR and it works as expected, I merged it and backported the fix to 3.8 and 3.9.

$ ./python -m profile -m http.server -h | head 
usage: http.server [-h] [--cgi] [--bind ADDRESS] [--directory DIRECTORY]
                   [port]

positional arguments:
  port                  Specify alternate port [default: 8000]

options:
  -h, --help            show this help message and exit
  --cgi                 Run as CGI Server
  --bind ADDRESS, -b ADDRESS

Previously, it wrote a long traceback:

$ python3.9 -m profile -m http.server -h | head 
usage: http.server [-h] [--cgi] [--bind ADDRESS] [--directory DIRECTORY]
                   [port]

positional arguments:
  port                  Specify alternate port [default: 8000]

optional arguments:
  -h, --help            show this help message and exit
  --cgi                 Run as CGI Server
  --bind ADDRESS, -b ADDRESS
Traceback (most recent call last):
  File "/usr/lib64/python3.9/runpy.py", line 197, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/usr/lib64/python3.9/runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "/usr/lib64/python3.9/profile.py", line 605, in <module>
    main()
  File "/usr/lib64/python3.9/profile.py", line 598, in main
    runctx(code, globs, None, options.outfile, options.sort)
  File "/usr/lib64/python3.9/profile.py", line 99, in runctx
    return _Utils(Profile).runctx(statement, globals, locals, filename, sort)
  File "/usr/lib64/python3.9/profile.py", line 66, in runctx
    self._show(prof, filename, sort)
  File "/usr/lib64/python3.9/profile.py", line 72, in _show
    prof.print_stats(sort)
  File "/usr/lib64/python3.9/profile.py", line 388, in print_stats
    pstats.Stats(self).strip_dirs().sort_stats(sort). \
  File "/usr/lib64/python3.9/pstats.py", line 431, in print_stats
    self.print_line(func)
  File "/usr/lib64/python3.9/pstats.py", line 519, in print_line
    print(func_std_string(func), file=self.stream)
BrokenPipeError: [Errno 32] Broken pipe

Thanks!