Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-46951: Order contents of zipapps #31713

Merged
merged 4 commits into from May 27, 2022

Conversation

hfinucane
Copy link
Contributor

@hfinucane hfinucane commented Mar 6, 2022

So that builds are more reproducible[1]. This almost happened for bpo-30693, but got punted.

[1]: If you want to get all the way there, you need to make sure that file mtimes are clamped, which I've been doing with shell magic. There is a patch I haven't tried, that looks promising, floating around on bpo.

https://bugs.python.org/issue46951

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@hfinucane

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

So that builds are more reproducible
@hfinucane hfinucane changed the title Order contents of zipapps bpo-46951: Order contents of zipapps Mar 8, 2022
@jacksonriley
Copy link
Contributor

Hi @serhiy-storchaka - it looks like this PR got stalled on CLA Signing, despite it looking like @hfinucane signed the CLA (given that "the-knights-who-say-ni added CLA signed" on 10th March). Do you know if there's a good way to kick the check?

(I was going to open an issue and a PR for this same fix, so was happy to see that there was already one in progress! 😄)

@pfmoore
Copy link
Member

pfmoore commented May 25, 2022

I'm afraid I don't know how to fix the CLA issue here. As it was lack of a bpo username and we've now migrated off bpo, maybe there's no issue any more? I don't know how to confirm this, though (or how to get the CLA check to rerun).

@jacksonriley
Copy link
Contributor

I'm afraid I don't know how to fix the CLA issue here. As it was lack of a bpo username and we've now migrated off bpo, maybe there's no issue any more? I don't know how to confirm this, though (or how to get the CLA check to rerun).

I think that closing and opening the PR will re-run the checks - worth a try @pfmoore? :)

@pfmoore pfmoore closed this May 25, 2022
@pfmoore pfmoore reopened this May 25, 2022
@pfmoore
Copy link
Member

pfmoore commented May 25, 2022

Seems to have worked, @jacksonriley - thanks!

@jacksonriley
Copy link
Contributor

Seems to have worked, @jacksonriley - thanks!

Nice one :) FWIW I think Serhiy's merge and push would have done the job as well, but all amounts to the same thing!

@jacksonriley
Copy link
Contributor

(Looks like just a make patchcheck needed to fix the Azure failure, but I don't have permissions)

@serhiy-storchaka serhiy-storchaka merged commit 47e68d4 into python:main May 27, 2022
@hfinucane hfinucane deleted the reproducible-zipapps branch May 27, 2022 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants