Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-93858: Prevent error when activating venv in nested fish instances (GH-93931) #93931

Merged
merged 1 commit into from Jun 27, 2022
Merged

gh-93858: Prevent error when activating venv in nested fish instances (GH-93931) #93931

merged 1 commit into from Jun 27, 2022

Conversation

thomasbbrunner
Copy link
Contributor

@thomasbbrunner thomasbbrunner commented Jun 17, 2022 •
edited by bedevere-bot

@cpython-cla-bot
Copy link

cpython-cla-bot bot commented Jun 17, 2022 •
edited

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-bot
Copy link

bedevere-bot commented Jun 17, 2022

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@thomasbbrunner thomasbbrunner marked this pull request as ready for review Jun 17, 2022
@thomasbbrunner thomasbbrunner requested a review from vsajip as a code owner Jun 17, 2022
@thomasbbrunner
Copy link
Contributor Author

thomasbbrunner commented Jun 27, 2022

@vsajip do you have any comments for this?

vsajip
vsajip approved these changes Jun 27, 2022
View changes
Copy link
Member

@vsajip vsajip left a comment

I'm not really experienced in the fish shell, but I'll approve it since it appears reasonable.

@vsajip vsajip changed the title gh-93858: Prevent error when activating venv in nested fish instances gh-93858: Prevent error when activating venv in nested fish instances (GH-93931) Jun 27, 2022
@vsajip vsajip merged commit 1172172 into python:main Jun 27, 2022
14 checks passed
@scarf005
Copy link

scarf005 commented Oct 18, 2022 •
edited

hi, thanks for bugfix. could this solution be backported to older versions (and 3.11)?

  • it'd be easy to backport since this PR is only for fish shell function
  • error persists on other python version, since it's tooling bug

@thomasbbrunner
Copy link
Contributor Author

thomasbbrunner commented Oct 18, 2022

I could work on this if there's interest from the maintainers. Just need some pointers on how to accomplish it.

@vsajip
Copy link
Member

vsajip commented Oct 18, 2022

could this solution be backported to older versions

Only to 3.10 and later.

I could work on this

Thanks, but there's no real work to do here other than copy the script changes from this patch - if you're interested in contributing, I'd suggest working on something more worthwhile in terms of engagement.

@miss-islington
Copy link
Contributor

miss-islington commented Oct 18, 2022

Thanks @thomasbbrunner for the PR, and @vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Oct 18, 2022

Thanks @thomasbbrunner for the PR, and @vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Oct 18, 2022

GH-98402 is a backport of this pull request to the 3.11 branch.

@bedevere-bot
Copy link

bedevere-bot commented Oct 18, 2022

GH-98403 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 18, 2022
@thomasbbrunner @miss-islington
pythongh-93858: Prevent error when activating venv in nested fish ins…
ce30c70 
…tances (pythonGH-93931)

(cherry picked from commit 1172172)

Co-authored-by: Thomas B. Brunner <thomasbbrunner@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 18, 2022
@thomasbbrunner @miss-islington
pythongh-93858: Prevent error when activating venv in nested fish ins…
b9f265a 
…tances (pythonGH-93931)

(cherry picked from commit 1172172)

Co-authored-by: Thomas B. Brunner <thomasbbrunner@gmail.com>
vsajip pushed a commit that referenced this pull request Oct 18, 2022
@miss-islington @thomasbbrunner
[3.11] gh-93858: Prevent error when activating venv in nested fish in…
11e1ed0 
…stances (GH-93931) (GH-98402)

Co-authored-by: Thomas B. Brunner <thomasbbrunner@gmail.com>
vsajip pushed a commit that referenced this pull request Oct 18, 2022
@miss-islington @thomasbbrunner
[3.10] gh-93858: Prevent error when activating venv in nested fish in…
ce87ab4 
…stances (GH-93931) (GH-98403)

Co-authored-by: Thomas B. Brunner <thomasbbrunner@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsajip vsajip

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

venv bug: Function “_old_fish_prompt” does not exist when activating venv in child process
5 participants
@thomasbbrunner @bedevere-bot @scarf005 @vsajip @miss-islington