bpo-30514: test_pop3lib asyncore with asyncio #1864
+128
−157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pop3 server stub was base on asyncore/asynchat which is deprecated, new stub is using asyncio instead. test_too_long_lines make sure we read remaining overlong response cmd_user answer only with +ERR message on invalid user
|
@grzgrzgrz3, thanks for your PR! By analyzing the history of the files in this pull request, we identified @tiran, @serhiy-storchaka and @giampaolo to be potential reviewers. |
Codecov Report
@@ Coverage Diff @@
## master #1864 +/- ##
=========================================
Coverage ? 82.68%
=========================================
Files ? 1432
Lines ? 353405
Branches ? 0
=========================================
Hits ? 292229
Misses ? 61176
Partials ? 0
Continue to review full report at Codecov.
|
|
This PR is stale because it has been open for 30 days with no activity. |
|
I'll work on getting this up to date so it unblocks removing asyncore. Note to self: local branch name is |
github-actions
bot
removed
the
stale
3 tasks
|
Triggering CLA. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Pop3 server stub was base on asyncore/asynchat which is deprecated, new
stub is using asyncio instead.
test_too_long_lines make sure we read remaining overlong response
cmd_user answer only with +ERR message on invalid user
#74699