Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PyCode_GetCode could be faster #93382

Closed
Fidget-Spinner opened this issue May 31, 2022 · 0 comments · Fixed by #93383
Closed

PyCode_GetCode could be faster #93382

Fidget-Spinner opened this issue May 31, 2022 · 0 comments · Fixed by #93383
Labels
3.12 interpreter-core performance

Comments

@Fidget-Spinner
Copy link
Contributor

@Fidget-Spinner Fidget-Spinner commented May 31, 2022 •
edited

This potentially affects tools like coverage.py. It also means anything using co_code in CPython frequently is significantly slower. Note that pre-3.11, most code would assume this operation is O(1), so it's probably called more often than we expect.

We should lazily initialise a hidden _co_code field and cache it there. Currently it creates a fresh bytes object on each co_code access. This is at best O(n).
@Fidget-Spinner Fidget-Spinner added the type-bug label May 31, 2022
@kumaraditya303 kumaraditya303 added performance and removed type-bug labels May 31, 2022
@Fidget-Spinner Fidget-Spinner mentioned this issue May 31, 2022
Merged
@Fidget-Spinner Fidget-Spinner changed the title PyCode_GetCode is really slow PyCode_GetCode could be faster May 31, 2022
@AA-Turner AA-Turner added interpreter-core 3.12 labels May 31, 2022
Fidget-Spinner added a commit that referenced this issue Jun 3, 2022
@Fidget-Spinner @kumaraditya303 @sweeneyde
gh-93382: Cache result of PyCode_GetCode in codeobject (GH-93383)
d52ffc1 
Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
Co-authored-by: Dennis Sweeney <36520290+sweeneyde@users.noreply.github.com>
Fidget-Spinner added a commit to Fidget-Spinner/cpython that referenced this issue Jun 4, 2022
@Fidget-Spinner @kumaraditya303 @sweeneyde
pythongh-93382: Cache result of PyCode_GetCode in codeobject (pytho…
13642ce 
…nGH-93383)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
Co-authored-by: Dennis Sweeney <36520290+sweeneyde@users.noreply.github.com>
@kumaraditya303 kumaraditya303 mentioned this issue Jun 11, 2022
Closed
@bedevere-bot bedevere-bot mentioned this issue Jun 22, 2022
Merged
pablogsal pushed a commit that referenced this issue Jun 23, 2022
@Fidget-Spinner @kumaraditya303 @sweeneyde
[3.11] gh-93382: Cache result of PyCode_GetCode in codeobject (GH-9…
852b4d4 
…3383) (#93493)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
Co-authored-by: Dennis Sweeney <36520290+sweeneyde@users.noreply.github.com>
@bedevere-bot bedevere-bot mentioned this issue Jun 24, 2022
Merged
Fidget-Spinner added a commit that referenced this issue Jun 24, 2022
@Fidget-Spinner
gh-93382: Sync up co_code changes with 3.11 (GH-94227)
50a5ab2 
Sync up co_code changes with 3.11 commit 852b4d4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.12 interpreter-core performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-93382: Cache result of PyCode_GetCode in codeobject Fidget-Spinner/cpython
3 participants
@AA-Turner @Fidget-Spinner @kumaraditya303