Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-95273: Clarify when the sqlite_* attributes are added to sqlite3 exceptions #95523

Merged
merged 1 commit into from Aug 1, 2022
Merged

gh-95273: Clarify when the sqlite_* attributes are added to sqlite3 exceptions #95523

merged 1 commit into from Aug 1, 2022

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Aug 1, 2022 •
edited by bedevere-bot

@erlend-aasland erlend-aasland requested a review from AlexWaygood Aug 1, 2022
@bedevere-bot bedevere-bot added awaiting core review docs Documentation in the Doc dir skip news labels Aug 1, 2022
@erlend-aasland erlend-aasland mentioned this pull request Aug 1, 2022
Closed
5 tasks
AlexWaygood
AlexWaygood approved these changes Aug 1, 2022
View changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

That was an easy one to review!

@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Aug 1, 2022

That was an easy one to review!

I remembered you said you were swamped with work at the moment, so I took the chance with a small PR :)

@erlend-aasland erlend-aasland merged commit 1e6b635 into python:main Aug 1, 2022
14 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Aug 1, 2022

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@erlend-aasland erlend-aasland deleted the sqlite-reference/improve-exception-accuracy branch Aug 1, 2022
@miss-islington
Copy link
Contributor

miss-islington commented Aug 1, 2022

Sorry, @erlend-aasland, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 1e6b63542e4856436c5c12148a6608ef9d148b71 3.10

@bedevere-bot
Copy link

bedevere-bot commented Aug 1, 2022

GH-95524 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 1, 2022
@erlend-aasland @miss-islington
pythongh-95273: Clarify when sqlite_* attributes are added to sqlite3…
f947a2e 
… exceptions (pythonGH-95523)

(cherry picked from commit 1e6b635)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
@erlend-aasland erlend-aasland linked an issue Aug 1, 2022 that may be closed by this pull request
Improve the sqlite3 reference #95273
Closed
5 tasks
@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Aug 1, 2022

Removing 3.10 backport, as 3.10 does not have this feature.

miss-islington added a commit that referenced this pull request Aug 1, 2022
@miss-islington @erlend-aasland
gh-95273: Clarify when sqlite_* attributes are added to sqlite3 excep…
ad2872f 
…tions (GH-95523)

(cherry picked from commit 1e6b635)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood

@berkerpeksag berkerpeksag

Assignees

@erlend-aasland erlend-aasland

Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve the sqlite3 reference
4 participants
@erlend-aasland @miss-islington @bedevere-bot @AlexWaygood