Fixed Mapbox Touch Event on Mobile After Switching Back from Select Mode #6281
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Note: "Mobile" in the following context means touch screen device.
Issue: When mobile user switched back to "Pan" mode from "Box Select" or "Lasso Select" on the mapbox graph, the user is unable to trigger events (eg: hover, click) that are initially trigger-able before switching to "Select" mode.
Problem: The event listener of "touchStart" is not removed.
Solution: Added remove event listener of "touchStart" code below remove event listener of "mouseDown" code when the mapbox graph is not in "Select" mode.
Other Observation: Double Touch on Screen to Clear Selection on "Pan" mode is not working after implementing this solution. But I guess it shouldn't be working at first since double click on "Pan" in non-mobile settings is also not clearing the selection.
Example: First graph in https://plotly.com/python/mapbox-layers/