Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mime] Fix inline parts when added via attachPart() #46963

Merged
merged 1 commit into from Jul 19, 2022

Conversation

fabpot
Copy link
Member

@fabpot fabpot commented Jul 17, 2022

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fixes #42921, Refs #46962
License MIT
Doc PR n/a

}
$attachmentParts[] = $this->createDataPart($attachment);

if ('inline' === $dispositionRef->getValue($part)) {
Copy link
Member Author

@fabpot fabpot Jul 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now, we always inline files when set explicitly as inline.

@flack
Copy link
Contributor

flack commented Jul 18, 2022

I tested this against 5.4.10, and it seems to fix the issue mentioned in #43255

@fabpot fabpot force-pushed the mime-attached-inline-part-not-related branch from e292247 to aeab24a Compare Jul 19, 2022
@fabpot fabpot merged commit 52a2eab into symfony:4.4 Jul 19, 2022
9 of 10 checks passed
@fabpot fabpot deleted the mime-attached-inline-part-not-related branch Jul 19, 2022
@xabbuh xabbuh mentioned this pull request Jul 29, 2022
fabpot added a commit that referenced this issue Jul 29, 2022
This PR was merged into the 6.2 branch.

Discussion
----------

[Mailer] re-add test

| Q             | A
| ------------- | ---
| Branch?       | 6.2
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

This test was initially added in #46211 but failed because of the changes from #46963 that were merged in the meantime. The test was then removed in e54dd38. This is a fixed version that is passing again.

Commits
-------

1026e16 re-add test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants