[Mime] Fix inline parts when added via attachPart() #46963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
fabpot
commented
Jul 17, 2022
•
| Q | A |
|---|---|
| Branch? | 4.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | Fixes #42921, Refs #46962 |
| License | MIT |
| Doc PR | n/a |
fabpot
force-pushed
the
mime-attached-inline-part-not-related
branch
from
1aeeb68
to
e292247
Compare
fabpot
reviewed
Jul 17, 2022
| } | ||
| $attachmentParts[] = $this->createDataPart($attachment); | ||
|
|
||
| if ('inline' === $dispositionRef->getValue($part)) { |
There was a problem hiding this comment.
Now, we always inline files when set explicitly as inline.
|
I tested this against 5.4.10, and it seems to fix the issue mentioned in #43255 |
stof
reviewed
Jul 18, 2022
fabpot
force-pushed
the
mime-attached-inline-part-not-related
branch
from
e292247
to
aeab24a
Compare
Merged
fabpot
added a commit
that referenced
this issue
Jul 29, 2022
This PR was merged into the 6.2 branch. Discussion ---------- [Mailer] re-add test | Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | This test was initially added in #46211 but failed because of the changes from #46963 that were merged in the meantime. The test was then removed in e54dd38. This is a fixed version that is passing again. Commits ------- 1026e16 re-add test
This was referenced Jul 29, 2022
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.