[Messenger] Fix function name in TriggerSql on postgresql bridge to support table name with schema #47070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
fabpot
approved these changes
Jul 27, 2022
thamine-cleverside
suggested changes
Jul 27, 2022
The PR fixes the bug, but still create the function inside the default schema (public)
I suggest to add this code in order to put the function in the specified schema
src/Symfony/Component/Messenger/Bridge/Doctrine/Transport/PostgreSqlConnection.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Messenger/Bridge/Doctrine/Transport/PostgreSqlConnection.php
Outdated
Show resolved
Hide resolved
zimny9932
force-pushed
the
messenger-postgres-trigger-sql-fix
branch
from
bf2c22e
to
c26d122
Compare
thamine-cleverside
approved these changes
Jul 28, 2022
carsonbot
changed the title
nicolas-grekas
changed the title
|
Thank you @zimny9932. |
fabpot
added a commit
that referenced
this issue
Jul 28, 2022
…bridge to support table name with schema (zimny9932) This PR was squashed before being merged into the 5.4 branch. Discussion ---------- [Messenger] Fix function name in TriggerSql on postgresql bridge to support table name with schema …support table name with schema | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #46984 | License | MIT Allow use schema in table_name option when configure postgresql transport. There was a problem with procedure name in getTriggerSql function in Symfony\Component\Messenger\Bridge\Doctrine\Transport\PostgreSqlConnection. Commits ------- 64e7c9b [Messenger] Fix function name in TriggerSql on postgresql bridge to support table name with schema
fabpot
force-pushed
the
messenger-postgres-trigger-sql-fix
branch
from
545cc3a
to
64e7c9b
Compare
This was referenced Jul 29, 2022
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
…support table name with schema
Allow use schema in table_name option when configure postgresql transport. There was a problem with procedure name in getTriggerSql function in Symfony\Component\Messenger\Bridge\Doctrine\Transport\PostgreSqlConnection.