[Intl] Fix the IntlDateFormatter::formatObject signature #46730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The same PR should be submitted to https://github.com/symfony/polyfill which is the new location of that code for Symfony 5+ |
stof
approved these changes
Jun 21, 2022
GromNaN
approved these changes
Jun 22, 2022
fabpot
approved these changes
Jun 22, 2022
OskarStark
approved these changes
Jun 22, 2022
|
Thank you @damienalexandre. |
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
I was calling
IntlDateFormatter::formatObjectin my user-land code and got this error from PHPStan:The Intl component
formatObjectmethod signature is indeed non-static, but the PHP Intl signature is.Reference: https://www.php.net/manual/en/intldateformatter.formatobject.php
So I think the component should respect PHP method signature.