Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Form] ignore the pattern attribute for textareas #39099

Merged
merged 1 commit into from Nov 27, 2020
Merged

[Form] ignore the pattern attribute for textareas #39099

merged 1 commit into from Nov 27, 2020

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Nov 17, 2020

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #39066
License MIT
Doc PR

@xabbuh xabbuh added this to the 4.4 milestone Nov 17, 2020
@xabbuh xabbuh requested a review from yceruto as a code owner Nov 17, 2020
@xabbuh xabbuh mentioned this pull request Nov 17, 2020
Closed
yceruto
yceruto reviewed Nov 17, 2020
View changes
Copy link
Member

@yceruto yceruto left a comment

The failed tests seem to be related.

@xabbuh
Copy link
Member Author

@xabbuh xabbuh commented Nov 17, 2020

The deps=high build will be green once changes have been merged up.

fabpot
fabpot approved these changes Nov 27, 2020
View changes
@fabpot
Copy link
Member

@fabpot fabpot commented Nov 27, 2020

Thank you @xabbuh.

@fabpot fabpot merged commit 1fb80e7 into symfony:4.4 Nov 27, 2020
4 of 5 checks passed
@xabbuh xabbuh deleted the issue-39066 branch Nov 27, 2020
This was referenced Nov 29, 2020
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot

@jderusse jderusse

@derrabus derrabus

@yceruto yceruto

Assignees
No one assigned
Labels
Bug Form Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@xabbuh @fabpot @jderusse @derrabus @yceruto @carsonbot