bpo-31538: Clarify the mailbox factory default #26776
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssarily lead to same result if passed
|
This PR is stale because it has been open for 30 days with no activity. |
|
I agree with you that is a problem and what you have added only deepens the issue and readers may want to know more so I think it would be a good idea to add your example. |
| @@ -447,8 +447,9 @@ Supported mailbox formats are Maildir, mbox, MH, Babyl, and MMDF. | |||
| is a callable object that accepts a file-like message representation (which | |||
| behaves as if opened in binary mode) and returns a custom representation. If | |||
| *factory* is ``None``, :class:`mboxMessage` is used as the default message | |||
| representation. If *create* is ``True``, the mailbox is created if it does not | |||
| exist. | |||
| representation (but this is not the same as setting *factory* to | |||
There was a problem hiding this comment.
If it's not the same, then what is the difference? I saw the example in the bpo, but I feel like we should explain what happens in the documentation too.
github-actions
bot
removed
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically, the mailbox factory default (and one of two subclasses) is not the same as passing the representation (class) that it returns to the factory (basically it does some extra processing).
No news entry required.
https://bugs.python.org/issue31538