Skip to content

bpo-44159 Change mimetype db to read windows registry values as non-strict #27088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

bpo-44159 Change mimetype db to read windows registry values as non-strict #27088

wants to merge 1 commit into from

Conversation

brandonschabell
Copy link
Contributor

@brandonschabell brandonschabell commented Jul 12, 2021 •
edited by bedevere-bot
Loading

bpo-44159 - Windows registry values are being used to set strict mimetypes.

This change changes the default behavior of the read_windows_registry function to add mimetypes in the registry as non-strict values. Prior to this change, test_guess_type in test_mimetypes.py would fail on Windows machines with a default mimetype for a .pic file set.

https://bugs.python.org/issue44159

@brandonschabell brandonschabell requested a review from a team as a code owner July 12, 2021 00:10
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@brandonschabell

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Aug 13, 2021
@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brandonschabell @the-knights-who-say-ni @ezio-melotti @bedevere-bot