Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Similar to test_pwd in test_grp, more tested for TypeError #95395

Closed
Yaminyam opened this issue Jul 28, 2022 · 3 comments
Closed

Similar to test_pwd in test_grp, more tested for TypeError #95395

Yaminyam opened this issue Jul 28, 2022 · 3 comments
Labels
tests Tests in the Lib/test dir

Comments

@Yaminyam
Copy link
Contributor

Yaminyam commented Jul 28, 2022

As grp and pwd modules behave similarly, I think that what is being tested in pwd should also be tested in grp.

add a test in which a number is entered as an argument to getgrnam() or a non-integer number is entered as an argument to getgrgid().
@Yaminyam Yaminyam added the type-feature A feature request or enhancement label Jul 28, 2022
@kumaraditya303 kumaraditya303 added tests Tests in the Lib/test dir and removed type-feature A feature request or enhancement labels Jul 28, 2022
@Yaminyam
Copy link
Contributor Author

Yaminyam commented Jul 28, 2022

Should I merge this issue into #95376?

@mdboom
Copy link
Contributor

mdboom commented Jul 28, 2022

I think it's ok if this remains a separate issue.

@bedevere-bot bedevere-bot mentioned this issue Jul 29, 2022
Merged
ambv pushed a commit that referenced this issue Aug 6, 2022
@Yaminyam
gh-95395: Add argument type error test (GH-95412)
4703c15
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Aug 6, 2022
@Yaminyam @miss-islington
pythongh-95395: Add argument type error test (pythonGH-95412)
80dd47d 
(cherry picked from commit 4703c15)

Co-authored-by: Sion Kang <31057849+Yaminyam@users.noreply.github.com>
@bedevere-bot bedevere-bot mentioned this issue Aug 6, 2022
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Aug 6, 2022
@Yaminyam @miss-islington
pythongh-95395: Add argument type error test (pythonGH-95412)
7eb82d6 
(cherry picked from commit 4703c15)

Co-authored-by: Sion Kang <31057849+Yaminyam@users.noreply.github.com>
@bedevere-bot bedevere-bot mentioned this issue Aug 6, 2022
Merged
ambv pushed a commit that referenced this issue Aug 6, 2022
@miss-islington @Yaminyam
gh-95395: Add argument type error test (GH-95412) (GH-95745)
9278fc4 
(cherry picked from commit 4703c15)

Co-authored-by: Sion Kang <31057849+Yaminyam@users.noreply.github.com>
ambv pushed a commit that referenced this issue Aug 6, 2022
@miss-islington @Yaminyam
gh-95395: Add argument type error test (GH-95412) (GH-95744)
0851032 
(cherry picked from commit 4703c15)

Co-authored-by: Sion Kang <31057849+Yaminyam@users.noreply.github.com>
@Yaminyam
Copy link
Contributor Author

Yaminyam commented Aug 9, 2022

This is now fixed in 3.10 - 3.12.

@Yaminyam Yaminyam closed this as completed Aug 9, 2022
iritkatriel pushed a commit to iritkatriel/cpython that referenced this issue Aug 11, 2022
@Yaminyam @iritkatriel
pythongh-95395: Add argument type error test (pythonGH-95412)
f060712
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mdboom @Yaminyam @kumaraditya303