Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-95876: Fix format string in pegen error location code #95877

Merged
merged 1 commit into from Aug 11, 2022
Merged

gh-95876: Fix format string in pegen error location code #95877

merged 1 commit into from Aug 11, 2022
+5 −1

Conversation

tiran
Copy link
Member

@tiran tiran commented Aug 11, 2022 •
edited by bedevere-bot

@pablogsal pablogsal merged commit b4c857d into python:main Aug 11, 2022
14 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Aug 11, 2022

Thanks @tiran for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this issue Aug 11, 2022
@tiran @miss-islington
pythongh-95876: Fix format string in pegen error location code (pytho…
383df7b 
…nGH-95877)

(cherry picked from commit b4c857d0fd74abb1ede6fe083c4fa3ca728b2b83)

Co-authored-by: Christian Heimes <christian@python.org>
@miss-islington
Copy link
Contributor

miss-islington commented Aug 11, 2022

Sorry, @tiran and @pablogsal, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker b4c857d0fd74abb1ede6fe083c4fa3ca728b2b83 3.10

@bedevere-bot
Copy link

bedevere-bot commented Aug 11, 2022

GH-95881 is a backport of this pull request to the 3.11 branch.

miss-islington added a commit that referenced this issue Aug 11, 2022
@miss-islington @tiran
gh-95876: Fix format string in pegen error location code (GH-95877)
1221e8c 
(cherry picked from commit b4c857d)

Co-authored-by: Christian Heimes <christian@python.org>
@pablogsal
Copy link
Member

pablogsal commented Aug 11, 2022

Sorry, @tiran and @pablogsal, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker b4c857d0fd74abb1ede6fe083c4fa3ca728b2b83 3.10

@tiran could you do the 3.10 backport?

tiran added a commit to tiran/cpython that referenced this issue Aug 11, 2022
@tiran
[3.10] pythongh-95876: Fix format string in pegen error location code (…
98c5309 
…pythonGH-95877).

(cherry picked from commit b4c857d)

Co-authored-by: Christian Heimes <christian@python.org>
miss-islington pushed a commit that referenced this issue Aug 11, 2022
@tiran
[3.10] gh-95876: Fix format string in pegen error location code (GH-9…
2a6b67f 
…5877 (GH-95901)

(cherry picked from commit b4c857d)

Co-authored-by: Christian Heimes <christian@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal

@lysnikolaou lysnikolaou

Assignees

@pablogsal pablogsal

Labels
needs backport to 3.10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tiran @miss-islington @bedevere-bot @pablogsal