Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-95896: posixmodule.c: osdefs.h inclusion should not depend on compiler #95897

Merged
merged 13 commits into from Nov 26, 2022
Merged

GH-95896: posixmodule.c: osdefs.h inclusion should not depend on compiler #95897

merged 13 commits into from Nov 26, 2022

Conversation

TheShermanTanker
Copy link
Contributor

@TheShermanTanker TheShermanTanker commented Aug 11, 2022 •
edited by bedevere-bot

@cpython-cla-bot
Copy link

cpython-cla-bot bot commented Aug 11, 2022 •
edited

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-bot
Copy link

bedevere-bot commented Aug 11, 2022

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@TheShermanTanker TheShermanTanker changed the title GH-95896 GH-95896: posixmodule.c: osdefs.h inclusion should not depend on compiler Aug 11, 2022
eryksun
eryksun reviewed Aug 11, 2022
View changes
Modules/posixmodule.c Show resolved Hide resolved
@bedevere-bot
Copy link

bedevere-bot commented Aug 12, 2022

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@bedevere-bot
Copy link

bedevere-bot commented Aug 12, 2022

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@bedevere-bot
Copy link

bedevere-bot commented Aug 13, 2022

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@bedevere-bot
Copy link

bedevere-bot commented Aug 14, 2022

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@bedevere-bot
Copy link

bedevere-bot commented Aug 14, 2022

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@TheShermanTanker
Copy link
Contributor Author

TheShermanTanker commented Aug 17, 2022

Merge success with latest

@JelleZijlstra JelleZijlstra requested a review from eryksun Oct 7, 2022
@kumaraditya303 kumaraditya303 requested a review from zooba Nov 25, 2022
@bedevere-bot bedevere-bot mentioned this pull request Nov 25, 2022
Closed
@bedevere-bot
Copy link

bedevere-bot commented Nov 25, 2022

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@zooba
Copy link
Member

zooba commented Nov 25, 2022

Apologies for the annoying bot. This change doesn't need a NEWS entry, so I removed it.

Can merge once CI is done, whether I get it or someone else, I don't mind.

@kumaraditya303 kumaraditya303 merged commit ec2b76a into python:main Nov 26, 2022
12 of 13 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Nov 26, 2022

Thanks @TheShermanTanker for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Nov 26, 2022

GH-99788 is a backport of this pull request to the 3.11 branch.

@bedevere-bot
Copy link

bedevere-bot commented Nov 26, 2022

GH-99789 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 26, 2022
@TheShermanTanker @zooba @miss-islington
pythonGH-95896: posixmodule.c: fix osdefs.h inclusion to not depend o…
aa23599 
…n compiler (pythonGH-95897)

(cherry picked from commit ec2b76a)

Co-authored-by: TheShermanTanker <32636402+TheShermanTanker@users.noreply.github.com>
Co-authored-by: Steve Dower <steve.dower@python.org>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 26, 2022
@TheShermanTanker @zooba @miss-islington
pythonGH-95896: posixmodule.c: fix osdefs.h inclusion to not depend o…
4819122 
…n compiler (pythonGH-95897)

(cherry picked from commit ec2b76a)

Co-authored-by: TheShermanTanker <32636402+TheShermanTanker@users.noreply.github.com>
Co-authored-by: Steve Dower <steve.dower@python.org>
miss-islington added a commit that referenced this pull request Nov 26, 2022
@miss-islington @TheShermanTanker @zooba
GH-95896: posixmodule.c: fix osdefs.h inclusion to not depend on comp…
3e3980b 
…iler (GH-95897)

(cherry picked from commit ec2b76a)

Co-authored-by: TheShermanTanker <32636402+TheShermanTanker@users.noreply.github.com>
Co-authored-by: Steve Dower <steve.dower@python.org>
miss-islington added a commit that referenced this pull request Nov 26, 2022
@miss-islington @TheShermanTanker @zooba
GH-95896: posixmodule.c: fix osdefs.h inclusion to not depend on comp…
610b779 
…iler (GH-95897)

(cherry picked from commit ec2b76a)

Co-authored-by: TheShermanTanker <32636402+TheShermanTanker@users.noreply.github.com>
Co-authored-by: Steve Dower <steve.dower@python.org>
@TheShermanTanker TheShermanTanker deleted the patch-1 branch Nov 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kumaraditya303 kumaraditya303

@eryksun eryksun

@zooba zooba

Assignees
No one assigned
Labels
3.10 3.11 3.12 extension-modules C modules in the Modules dir OS-windows skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@TheShermanTanker @bedevere-bot @zooba @miss-islington @eryksun @kumaraditya303