Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-95245: Move weakreflist into the pre-header. #95996

Merged
merged 8 commits into from Aug 16, 2022

Conversation

markshannon
Copy link
Member

@markshannon markshannon commented Aug 15, 2022

A more robust version of #95657 that allows third party code to have managed weakrefs.

@ericsnowcurrently ericsnowcurrently self-requested a review Aug 15, 2022
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Mostly LGTM (a few minor comments)

Lib/test/test_capi.py Show resolved Hide resolved
Include/internal/pycore_object.h Show resolved Hide resolved
Include/internal/pycore_object.h Show resolved Hide resolved
Objects/typeobject.c Outdated Show resolved Hide resolved
@bedevere-bot
Copy link

bedevere-bot commented Aug 15, 2022

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@markshannon markshannon added 🔨 test-with-buildbots Test PR w/ buildbots; report in status section and removed awaiting changes labels Aug 16, 2022
@bedevere-bot
Copy link

bedevere-bot commented Aug 16, 2022

🤖 New build scheduled with the buildbot fleet by @markshannon for commit 0dedf78 🤖

If you want to schedule another build, you need to add the "🔨 test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Aug 16, 2022
@markshannon markshannon merged commit 5a8c158 into python:main Aug 16, 2022
78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants