Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove trailing spaces #31695

Merged
merged 1 commit into from Mar 5, 2022

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Mar 5, 2022

No description provided.

@@ -18,7 +18,7 @@
#endif

#include "Python.h"
Copy link
Member

@Fidget-Spinner Fidget-Spinner Mar 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the changes in this file accidental?

Copy link
Member Author

@serhiy-storchaka serhiy-storchaka Mar 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a generated file. After regenerating all I got this.

@JelleZijlstra
Copy link
Member

JelleZijlstra commented Mar 5, 2022

Thanks for fixing this!

Is there a place we could check for trailing spaces in CI? I'd rather not have to periodically check for this and make another similar PR.

@serhiy-storchaka
Copy link
Member Author

serhiy-storchaka commented Mar 5, 2022

AFAIK there were scripts and Makefile targets, but they were disabled.

@serhiy-storchaka serhiy-storchaka merged commit 6927632 into python:main Mar 5, 2022
12 checks passed
@serhiy-storchaka serhiy-storchaka deleted the trailing-spaces branch Mar 5, 2022
@erlend-aasland
Copy link
Contributor

erlend-aasland commented Mar 5, 2022

Thanks for fixing this!

Is there a place we could check for trailing spaces in CI? I'd rather not have to periodically check for this and make another similar PR.

+1 from me. Let's open an issue over at python/core-workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants